bitcoin-cli: note -rpcclienttimeout is not implemented for IPC connections #35015

pull ryanofsky wants to merge 1 commits into bitcoin:master from ryanofsky:pr/ipc-timeout changing 1 files +1 −1
  1. ryanofsky commented at 5:38 PM on April 6, 2026: contributor

    The -rpcclienttimeout option applies only to HTTP connections. When bitcoin-cli connects via IPC, the timeout is silently ignored. Clarify this in the help string.

    Noted by pinheadmz in #32297#pullrequestreview-3922849038

  2. DrahtBot commented at 5:38 PM on April 6, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35015.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    Stale ACK sedited, enirox001

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    No conflicts as of last run.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  3. sedited approved
  4. sedited commented at 12:05 PM on April 20, 2026: contributor

    ACK 12418a610bdc34e40be7cf4a26b172cc9c1191c3

  5. DrahtBot added the label Needs rebase on Apr 20, 2026
  6. enirox001 commented at 10:04 AM on April 21, 2026: contributor

    ACK 12418a6

  7. bitcoin-cli: note -rpcclienttimeout is not implemented for IPC connections
    The `-rpcclienttimeout` option applies only to HTTP connections. When
    `bitcoin-cli` connects via IPC, the timeout is silently ignored. Clarify this
    in the help string.
    
    Noted by pinheadmz in
    https://github.com/bitcoin/bitcoin/pull/32297#pullrequestreview-3922849038
    08c3c37d12
  8. ryanofsky force-pushed on May 6, 2026
  9. ryanofsky commented at 9:18 AM on May 6, 2026: contributor

    <!-- begin push-2 -->

    Rebased 12418a610bdc34e40be7cf4a26b172cc9c1191c3 -> 08c3c37d12351d14de5a48c2a4b5a32949efd5e9 (pr/ipc-timeout.1 -> pr/ipc-timeout.2, compare)<!-- end --> due to conflict with #35006

  10. DrahtBot removed the label Needs rebase on May 6, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:52 UTC