doc: remove unshipped doc references from help and warning text #34839

pull AgusR7 wants to merge 2 commits into bitcoin:master from AgusR7:doc/unshipped-doc-links-helptext changing 5 files +8 −14
  1. AgusR7 commented at 5:51 AM on March 17, 2026: none

    This is a small follow-up to #34693 and addresses the remaining C++ help/warning strings discussed in #32565.

    Some help and warning strings in bitcoind and bitcoin-wallet currently refer to markdown files under doc/ that are available in the source tree but are not shipped with Bitcoin Core binaries. This makes those messages less useful for users running distributed binaries.

    This PR removes those references from:

    • src/init.cpp
    • src/wallet/init.cpp

    The scope is intentionally narrow. It does not:

    • change behavior
    • ship documentation files
    • refactor the help system

    Testing:

    • git diff --check

    No new tests were added, since this change only updates user-facing help/warning text and does not modify behavior. Fixes #32565.

  2. doc: remove unshipped doc references from help and warning text 4ed0cc624f
  3. DrahtBot added the label Docs on Mar 17, 2026
  4. DrahtBot commented at 5:52 AM on March 17, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34839.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    Concept ACK fanquake
    Stale ACK savagemechanic

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #35027 (net: use -bind address for outgoing connections by 8144225309)
    • #31974 (Drop testnet3 by Sjors)
    • #31260 (scripted-diff: Type-safe settings retrieval by ryanofsky)
    • #17783 (common: Disallow calling IsArgSet() on ALLOW_LIST options by ryanofsky)
    • #17581 (refactor: Remove settings merge reverse precedence code by ryanofsky)
    • #17580 (refactor: Add ALLOW_LIST flags and enforce usage in CheckArgFlags by ryanofsky)
    • #17493 (util: Forbid ambiguous multiple assignments in config file by ryanofsky)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

    LLM Linter (✨ experimental)

    Possible typos and grammar issues:

    • specified by below -> specified below [broken phrase; the intended meaning is clear only after guessing]

    <sup>2026-05-19 02:22:09</sup>

  5. savagemechanic commented at 1:21 AM on May 18, 2026: none

    ACK 4ed0cc624f8b3457f632ac1698270d2f40bcfe91

    Reviewed the diff and verified that the touched help/warning files no longer contain doc/*.md references.

    Ran:

    • git diff --check 52e8c1ce32a24d94b8fe06fa5e17bf8a176e50f0..HEAD
    • rg -n 'doc/[A-Za-z0-9_./-]+\\.md|doc/[A-Za-z0-9_./-]+' src/init.cpp src/wallet/init.cpp\n\nI did not build binaries, since this is a help/warning text-only change.
  6. fanquake commented at 11:03 AM on May 18, 2026: member

    Concept ACK - You've missed a few:

    • doc/policy/packages.md
    • doc/design/assumeutxo.md (links to master, not sure we want that)
    • doc/descriptors.md
  7. doc: remove unshipped doc references from RPC help 1609000704
  8. AgusR7 commented at 2:22 AM on May 19, 2026: none

    Updated in 160900070476cff1f79d0e7a7aefbf7ffe7979cc.

    This removes the additional C++ RPC help references mentioned in the CACK:

    • doc/policy/packages.md from submitpackage
    • doc/design/assumeutxo.md / the master-branch link from loadtxoutset
    • doc/descriptors.md from both scantxoutset and deriveaddresses

    Re-ran:

    • git diff --check 52e8c1ce32a24d94b8fe06fa5e17bf8a176e50f0..HEAD
    • rg -n "doc/(policy/packages|design/assumeutxo|descriptors)\.md|github\.com/bitcoin/bitcoin/blob/master/doc/design/assumeutxo\.md" src/rpc src/init.cpp src/wallet/init.cpp

    The grep now returns no matches. I did not build binaries, since this is still only help text changes.


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:51 UTC