Now that we build capnp, qt isn't the only native package.
doc: fix `LIBRARY_PATH` comment #33308
pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:correct_native_comment changing 1 files +1 −1-
fanquake commented at 4:33 PM on September 4, 2025: member
-
a2a35b58cb
doc: fix LIBRARY_PATH comment
Now that we build capnp, qt isn't the only native package.
- DrahtBot added the label Docs on Sep 4, 2025
-
DrahtBot commented at 4:33 PM on September 4, 2025: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33308.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK l0rinc, willcl-ark If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #32764 (guix: Build for macOS using Clang only by hebasto)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
- l0rinc approved
-
l0rinc commented at 7:00 PM on September 4, 2025: contributor
code review ACK a2a35b58cb957b7fba113eb4cf933d5e7b9bf8ef
- willcl-ark approved
-
willcl-ark commented at 7:25 PM on September 4, 2025: member
ACK a2a35b58cb957b7fba113eb4cf933d5e7b9bf8ef
-
in contrib/guix/libexec/build.sh:77 in a2a35b58cb
73 | @@ -74,7 +74,7 @@ build_CC="${NATIVE_GCC}/bin/gcc -isystem ${NATIVE_GCC}/include" 74 | build_CXX="${NATIVE_GCC}/bin/g++ -isystem ${NATIVE_GCC}/include/c++ -isystem ${NATIVE_GCC}/include" 75 | 76 | case "$HOST" in 77 | - *darwin*) export LIBRARY_PATH="${NATIVE_GCC}/lib" ;; # Required for qt/qmake 78 | + *darwin*) export LIBRARY_PATH="${NATIVE_GCC}/lib" ;; # Required for native packages
hebasto commented at 8:14 PM on September 4, 2025:While the comment's amendment is correct, the comment itself should by applied to both
darwin*andmingw*hosts.
fanquake commented at 11:49 PM on September 4, 2025:I think it's clear it applies to both, given it's the same code?
hebasto commented at 2:21 PM on September 5, 2025:I think it's clear it applies to both, given it's the same code?
Yes, that’s certainly one way to look at it. I’m willing to admit it might just be my own bias to think that an inline comment applies only to the specific line it’s attached to.
That could explain why I (mistakenly) removed the comment along with the code in #32764.
fanquake merged this on Sep 8, 2025fanquake closed this on Sep 8, 2025fanquake deleted the branch on Sep 8, 2025alexanderwiederin referenced this in commit 49e068b15b on Sep 16, 2025alexanderwiederin referenced this in commit 4b0c2f2a8f on Sep 17, 2025alexanderwiederin referenced this in commit 2edb618ffe on Sep 17, 2025stringintech referenced this in commit fb8510ba20 on Sep 17, 2025bug-castercv502 referenced this in commit 9f5d12d027 on Sep 28, 2025yuvicc referenced this in commit d89c6d0002 on Sep 28, 2025stickies-v referenced this in commit a785fe6759 on Nov 5, 2025Kino1994 referenced this in commit 8e599bc8bf on Jun 28, 2026BigcoinBGC referenced this in commit 5169d484a9 on Jun 30, 2026Kino1994 referenced this in commit 2184344dfd on Aug 19, 2026bitcoin locked this on Sep 8, 2026ContributorsLabels
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-09-09 07:56 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-09-09 07:56 UTC