The assumption was removed in commit 3eab8b724044dc321f70e5eed66b149713158a04.
test: Fixup fill_mempool docstring #33269
pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2508-test-fill-mempool-docs changing 1 files +1 −2-
maflcko commented at 6:15 AM on August 29, 2025: member
-
fa3f682032
test: Fixup fill_mempool docstring
The assumption was removed in commit 3eab8b724044dc321f70e5eed66b149713158a04.
- DrahtBot added the label Tests on Aug 29, 2025
-
DrahtBot commented at 6:15 AM on August 29, 2025: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33269.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK l0rinc, enirox001, pablomartin4btc, naiyoma If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
- l0rinc approved
-
l0rinc commented at 7:45 PM on August 29, 2025: contributor
ACK fa3f682032a3292604f363a5ee4557937f3d8950
-
enirox001 commented at 9:27 PM on August 29, 2025: contributor
ACK https://github.com/bitcoin/bitcoin/commit/fa3f682 - docstring cleanup, looks good.
- pablomartin4btc approved
-
pablomartin4btc commented at 9:57 PM on August 29, 2025: member
ACK fa3f682032a3292604f363a5ee4557937f3d8950
(Or adding back the assert correcting the value (0.00000100) and the comment (0.1)?)
-
naiyoma commented at 10:59 AM on August 31, 2025: contributor
ACK fa3f682032a3292604f363a5ee4557937f3d8950
- fanquake merged this on Sep 2, 2025
- fanquake closed this on Sep 2, 2025
- maflcko deleted the branch on Sep 2, 2025
- alexanderwiederin referenced this in commit 49e068b15b on Sep 16, 2025
- alexanderwiederin referenced this in commit 4b0c2f2a8f on Sep 17, 2025
- alexanderwiederin referenced this in commit 2edb618ffe on Sep 17, 2025
- stringintech referenced this in commit fb8510ba20 on Sep 17, 2025
- bug-castercv502 referenced this in commit 9f5d12d027 on Sep 28, 2025
- yuvicc referenced this in commit d89c6d0002 on Sep 28, 2025
- stickies-v referenced this in commit a785fe6759 on Nov 5, 2025
- Kino1994 referenced this in commit ee5271a411 on Jun 28, 2026
- BigcoinBGC referenced this in commit 2cc7f185a9 on Jun 30, 2026
- Kino1994 referenced this in commit bfb6114282 on Aug 19, 2026
- bitcoin locked this on Sep 2, 2026