fuzz: Add missing calls to `SetMockTime` for determinism #32927

pull maflcko wants to merge 3 commits into bitcoin:master from maflcko:2507-fuzz-missing-mocktime changing 10 files +12 −3
  1. maflcko commented at 12:49 PM on July 9, 2025: member

    (Tracking issue #29018)

    During fuzzing, AppInitParameterInteraction may actually disable a previously set mocktime. This is confusing and can also cause non-determinism.

    Fix this issue, by

    • fixing the erroneous -mocktime parsing in AppInitParameterInteraction.
    • adding the missing SetMockTime calls to the affected fuzz init functions.
    • adding a CheckGlobals to the fuzz init, to prevent this issue in the future.

    This can be tested by

    • Cherry-picking the CheckGlobals-commit onto current master and observing a fuzz failure in the touched fuzz targets.
    • Reverting the touched fuzz fixups and observing a fuzz failure for each target.
  2. Add SetMockTime for time_point types fa6b45fa8e
  3. test: Avoid resetting mocktime in testing setup
    This allows to set the mocktime before the testing setup.

Also, in some fuzz tests the mocktime was reset to 0 before this change,
so set it.
    fa26bfde98
  4. fuzz: CheckGlobals in init fa8862723c
  5. DrahtBot added the label Tests on Jul 9, 2025
  6. DrahtBot commented at 12:49 PM on July 9, 2025: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32927.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK w0xlt, dergoegge

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #32822 (fuzz: Make process_message(s) more deterministic by maflcko)
    • #32430 (test: Add and use ElapseTime helper by maflcko)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  7. fanquake requested review from dergoegge on Jul 10, 2025
  8. fanquake requested review from marcofleon on Jul 10, 2025
  10. dergoegge approved
  11. dergoegge commented at 9:40 AM on July 11, 2025: member

    utACK fa8862723c14cdd471bbffc7a4897ece2e6d8a7f

  12. fanquake merged this on Jul 11, 2025
  13. fanquake closed this on Jul 11, 2025
  14. marcofleon commented at 11:07 AM on July 11, 2025: contributor

    post merge ACK fa8862723c14cdd471bbffc7a4897ece2e6d8a7f

  15. maflcko deleted the branch on Jul 11, 2025
  16. stringintech referenced this in commit f19e7819e9 on Jul 19, 2025
  17. alexanderwiederin referenced this in commit 9997c3d993 on Jul 25, 2025
  18. alexanderwiederin referenced this in commit 8d6ebb9c4e on Jul 28, 2025
  19. alexanderwiederin referenced this in commit 533a4585b5 on Jul 28, 2025
  20. yuvicc referenced this in commit 22f55cf11d on Aug 26, 2025
  21. bug-castercv502 referenced this in commit d4bd8a1259 on Sep 28, 2025
  22. fanquake added the label Fuzzing on Oct 30, 2025
  23. stickies-v referenced this in commit a19c56cd7c on Nov 4, 2025
  24. Kino1994 referenced this in commit 337c729864 on Jun 28, 2026
  25. BigcoinBGC referenced this in commit 50a353cce8 on Jun 30, 2026
  26. Kino1994 referenced this in commit 47b23ce147 on Aug 19, 2026
  27. bitcoin locked this on Oct 30, 2026
Contributors
maflckoDrahtBotw0xltdergoeggemarcofleon
Labels
TestsFuzzing
Linked (view graph)
#29018 fuzz: Fix stability, determinism issues
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-10-30 09:41 UTC