test: Avoid intermittent block download timeout in p2p_ibd_stalling #30705

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2408-test-stall-not-timeout changing 1 files +2 −1
  1. maflcko commented at 3:52 PM on August 23, 2024: member

    Fixes #30704

    The goal of the test is to check the stalling timeout, not the block download timeout.

    On extremely slow hardware (for example qemu virtual hardware), downloading the 1023 blocks may take longer than the block download timeout.

    Fix it by pinning the time using mocktime, and only advance it when testing the stalling timeout.

  2. test: Avoid intermittent block download timeout in p2p_ibd_stalling fa5b58ea01
  3. DrahtBot commented at 3:52 PM on August 23, 2024: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK tdb3, brunoerg

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. DrahtBot added the label Tests on Aug 23, 2024
  5. tdb3 approved
  6. tdb3 commented at 12:32 AM on August 25, 2024: contributor

    CR ACK fa5b58ea01fac1adb6336b8b6b5217193295c695

  7. brunoerg approved
  8. brunoerg commented at 12:45 PM on August 26, 2024: contributor

    utACK fa5b58ea01fac1adb6336b8b6b5217193295c695

  9. fanquake merged this on Aug 27, 2024
  10. fanquake closed this on Aug 27, 2024
  11. maflcko deleted the branch on Aug 27, 2024
  12. fanquake referenced this in commit a74bdeea1b on Sep 2, 2024
  13. PastaPastaPasta referenced this in commit b8314683af on Oct 25, 2024
  14. PastaPastaPasta referenced this in commit 49a36866e8 on Oct 26, 2024
  15. PastaPastaPasta referenced this in commit b6544791b4 on Oct 27, 2024
  16. PastaPastaPasta referenced this in commit 565f2db930 on Oct 27, 2024
  17. maflcko commented at 7:19 AM on November 28, 2024: member

    Fixup in #31383

  18. Fabcien referenced this in commit 5396e280be on Dec 21, 2024
  19. roqqit referenced this in commit bb8ebb3e4c on Jan 7, 2025
  20. bitcoin locked this on Nov 28, 2025
Contributors
maflckoDrahtBottdb3brunoerg
Labels
Tests
Linked (view graph)
#30704 Intermittent timeout on p2p_ibd_stalling.py#30761 test: Avoid intermittent timeout in p2p_headers_sync_with_minchainwork.py
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:52 UTC