Update functional test runner to return error code when no tests are found to run #29576

1. 
   m3dwards commented at 1:21 PM on March 6, 2024: contributor

   As discussed in the following PR comment: #29535 (comment)

   Prevents the test_runner from exiting silently with code 0 when no tests were found which has recently happened after a GHA runner update such as in this run: https://github.com/bitcoin/bitcoin/actions/runs/8131828989/job/22239779585#step:27:63

2. test: exit with code 1 when no fn tests are found

   Prevents the test_runner from exiting silently with code 0 when no tests were found.

   33268a8558
3. 
   DrahtBot commented at 1:21 PM on March 6, 2024: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--006a51241073e994b41acfe9ec718e94-->

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	TheCharlatan, theStack
   Concept ACK	fanquake, BrandonOdiwuor

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. willcl-ark added the label Tests on Mar 6, 2024
5. 
   fanquake commented at 1:27 PM on March 6, 2024: member

   Concept ACK. This would have caught the silent breakage from #29534.

6. 
   BrandonOdiwuor commented at 2:29 PM on March 6, 2024: contributor

   Concept ACK

7. TheCharlatan approved
8. 
   TheCharlatan commented at 3:43 PM on March 6, 2024: contributor

   ACK 33268a855883142a039a7a7b14eb1345e52809fd

9. DrahtBot requested review from fanquake on Mar 6, 2024
10. DrahtBot requested review from BrandonOdiwuor on Mar 6, 2024
11. theStack approved
12. 
    theStack commented at 10:35 PM on March 6, 2024: contributor

    lgtm ACK 33268a855883142a039a7a7b14eb1345e52809fd

13. DrahtBot removed review request from BrandonOdiwuor on Mar 6, 2024
14. DrahtBot requested review from BrandonOdiwuor on Mar 6, 2024
15. fanquake merged this on Mar 7, 2024
16. fanquake closed this on Mar 7, 2024

    ---

17. 
    hebasto commented at 12:00 PM on March 7, 2024: member

    Post-merge ACK 33268a855883142a039a7a7b14eb1345e52809fd.

    Thank you @m3dwards :)

18. m3dwards deleted the branch on Mar 7, 2024
19. PastaPastaPasta referenced this in commit d2c0d4b2ca on Oct 24, 2024
20. PastaPastaPasta referenced this in commit 3e33fc7bbe on Oct 24, 2024
21. PastaPastaPasta referenced this in commit 4dce690a5e on Oct 24, 2024
22. PastaPastaPasta referenced this in commit aaccc9ea51 on Oct 24, 2024
23. bitcoin locked this on Mar 7, 2025

Contributors

m3dwardsDrahtBotfanquakeBrandonOdiwuorTheCharlatantheStackhebasto

Review Requested
fanquakeBrandonOdiwuor