test: Add test to check tx in the last block can be downloaded #27695

1. 
   maflcko commented at 9:44 AM on May 18, 2023: member

   If a peer received an inv about a transaction, which was included in a block before receiving the corresponding getdata, it can be beneficial to send this transaction to the peer to aid compact block relay.

   Add a test for this to avoid breaking it in the future.

2. test: Split up test_notfound_on_unannounced_tx test case fadc8490ab
3. test: Add test to check tx in the last block can be downloaded fa4c16b186
4. 
   DrahtBot commented at 9:44 AM on May 18, 2023: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	sdaftuar, instagibbs

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

5. DrahtBot renamed this:
   test: Add test to check tx in the last block can be downloaded
   test: Add test to check tx in the last block can be downloaded
   on May 18, 2023
6. DrahtBot added the label Tests on May 18, 2023
7. fanquake requested review from theStack on May 18, 2023
8. maflcko cross-referenced this on May 18, 2023 from issue p2p: Stop relaying non-mempool txs by maflcko
9. 
   sdaftuar commented at 3:02 PM on May 18, 2023: member

   ACK fa4c16b186a34f4172deda617166813c8cb92c59

10. fanquake requested review from instagibbs on May 18, 2023
11. instagibbs approved
12. 
    instagibbs commented at 5:08 PM on May 18, 2023: member

    ACK fa4c16b186a34f4172deda617166813c8cb92c59

    broke test intentionally by disabling non-mempool checks in PeerManagerImpl::FindTxForGetData, resulted in expected failure

13. fanquake merged this on May 19, 2023
14. fanquake closed this on May 19, 2023

    ---

15. maflcko deleted the branch on May 19, 2023
16. sidhujag referenced this in commit 3cad197251 on May 19, 2023
17. bitcoin locked this on May 18, 2024

Contributors

maflckoDrahtBotsdaftuarinstagibbs

Review Requested
theStack