We no-longer run any security/symbol checks in the CI, and doubt we will in future (if we do, it'll be via Guix, where this var would be redundant in any case). The CI environment doesn't (exactly) match the release build environment (and is semi-regularly changing), and the binaries produced in the CI don't match how we build release binaries, so there is no point trying to run these checks, especially as we add more involved tests, i.e #26953.
ci: remove `RUN_SECURITY_TESTS` #27683
pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:remove_RUN_SECURITY_TESTS changing 2 files +0 −5-
fanquake commented at 9:58 AM on May 17, 2023: member
-
6a936580d1
ci: remove RUN_SECURITY_TESTS
We no-longer run any security/syymbol checks in the CI, and doubt we will in future (if we do, it'll be via Guix, where this var would be redundant in any case). The CI environment doesn't (exactly) match the release build environment (and is semi-regularly changing), and the binaries produced in the CI don't match how we build release binaries, so there is no point trying to run these checks, especially as we add more involved tests, i.e #26953.
-
DrahtBot commented at 9:58 AM on May 17, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK josibake, TheCharlatan Concept ACK hebasto If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- DrahtBot added the label Tests on May 17, 2023
- fanquake cross-referenced this on May 17, 2023 from issue macOS: Bump minimum required runtime version and prepare for building with upstream LLVM by theuni
- fanquake cross-referenced this on May 17, 2023 from issue ci: Use `macos-ventura-xcode:14.1` image for "macOS native" task by hebasto
-
hebasto commented at 10:21 AM on May 17, 2023: member
We no-longer run any security/symbol checks in the CI, and doubt we will in future (if we do, it'll be via Guix, where this var would be redundant in any case).
Concept ACK on that.
- fanquake requested review from josibake on May 20, 2023
-
josibake commented at 11:04 AM on May 20, 2023: member
code review ACK https://github.com/bitcoin/bitcoin/pull/27683/commits/6a936580d1c42576f627d5fac5423ec7af88e547
+1 on removing "off by default" stuff from the CI scripts. also agree that guix is the right place to be handling these sorts of checks
- DrahtBot removed review request from josibake on May 20, 2023
- TheCharlatan approved
-
TheCharlatan commented at 8:08 PM on May 20, 2023: contributor
ACK 6a936580d1c42576f627d5fac5423ec7af88e547
Doesn't make sense to maintain this.
- fanquake merged this on May 22, 2023
- fanquake closed this on May 22, 2023
- fanquake deleted the branch on May 22, 2023
- sidhujag referenced this in commit 93833d3884 on May 23, 2023
- bitcoin locked this on May 21, 2024
Contributors
Labels