ci: Remove CI_EXEC bloat in test/06_script_b.sh #27573

pull maflcko wants to merge 3 commits into bitcoin:master from maflcko:2305-ci-exec-no- changing 4 files +78 −73
  1. maflcko commented at 4:19 PM on May 4, 2023: member

    CI_EXEC has many issues:

    • It is roughly equivalent to bash -c "$*", meaning that the full command will be treated as a single string, ignoring tokens.
    • It must be put in front of (almost) every command, making it easy to forget, hard to debug the resulting failure, and the code verbose.

    Fix all issues in one script by removing it.

  2. DrahtBot commented at 4:19 PM on May 4, 2023: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK fanquake, TheCharlatan

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #27571 (ci: Run iwyu on all src files by MarcoFalke)
    • #27530 (Remove now-unnecessary poll, fcntl includes from net(base).cpp by Empact)
    • #27425 (test: move remaining rand code from util/setup_common to util/random by jonatack)
    • #27385 (net, refactor: extract Network and BIP155Network logic to node/network by jonatack)
    • #25797 (build: Add CMake-based build system by hebasto)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  3. DrahtBot renamed this:
    ci: Remove CI_EXEC bloat in test/06_script_b.sh
    ci: Remove CI_EXEC bloat in test/06_script_b.sh
    on May 4, 2023
  4. DrahtBot added the label Tests on May 4, 2023
  5. maflcko force-pushed on May 4, 2023
  6. DrahtBot added the label CI failed on May 4, 2023
  7. maflcko force-pushed on May 4, 2023
  8. maflcko force-pushed on May 4, 2023
  9. maflcko force-pushed on May 4, 2023
  10. maflcko force-pushed on May 4, 2023
  11. maflcko force-pushed on May 4, 2023
  12. maflcko force-pushed on May 4, 2023
  13. DrahtBot cross-referenced this on May 4, 2023 from issue ci: Run iwyu on all src files by maflcko
  14. maflcko force-pushed on May 4, 2023
  15. maflcko force-pushed on May 4, 2023
  16. maflcko force-pushed on May 4, 2023
  17. maflcko force-pushed on May 4, 2023
  18. maflcko force-pushed on May 4, 2023
  19. maflcko force-pushed on May 4, 2023
  20. maflcko force-pushed on May 4, 2023
  21. maflcko force-pushed on May 4, 2023
  22. DrahtBot removed the label CI failed on May 4, 2023
  23. DrahtBot cross-referenced this on May 5, 2023 from issue kernel: Remove args, settings, chainparams, chainparamsbase from kernel library by TheCharlatan
  24. DrahtBot cross-referenced this on May 5, 2023 from issue Remove now-unnecessary poll, fcntl includes from net(base).cpp by Empact
  25. DrahtBot cross-referenced this on May 5, 2023 from issue test: move remaining rand code from util/setup_common to util/random by jonatack
  26. DrahtBot cross-referenced this on May 5, 2023 from issue net, refactor: extract Network and BIP155Network logic to node/network by jonatack
  27. DrahtBot cross-referenced this on May 5, 2023 from issue refactor, kernel: Decouple ArgsManager from blockstorage by TheCharlatan
  28. ci: Pass full env to CI pod to avoid missing a var
    Instead of enumerating each passed env var, just pass all. This avoids
    the risk of missing to enumerate one. Also, it is less code.
    
    The risk could be that an env var causes non-deterministic behavior, but
    this can be fixed by explicitly excluding it once the issue is known.
    
    Values with newlines can not be stored in the file and parsed by
    docker/podman, so they are excluded.
    fa7d75540e
  29. ci: Move CI container kill out of 06_script_b.sh
    This cleans up 06_script_b.sh to only contain code to be executed inside
    the CI pod, which avoids confusion and is needed for the next commit.
    fae8de926a
  30. ci: Remove CI_EXEC bloat in test/06_script_b.sh fa1dbd04ca
  31. maflcko force-pushed on May 5, 2023
  32. maflcko cross-referenced this on May 5, 2023 from issue ci: Add test coverage job by aureleoules
  33. DrahtBot cross-referenced this on May 6, 2023 from issue build: Add CMake-based build system by hebasto
  34. fanquake approved
  35. fanquake commented at 2:38 PM on May 9, 2023: member

    ACK fa1dbd04cab8039440e721eddabb760a40ba8c61 - this conflicts with #27125, but that is going to be rebased soon, and this could be merged in the interim. cc TheCharlatan

  36. TheCharlatan approved
  37. TheCharlatan commented at 10:39 AM on May 10, 2023: contributor

    ACK fa1dbd04cab8039440e721eddabb760a40ba8c61

  38. fanquake commented at 10:55 AM on May 10, 2023: member

    Merging this now. #27125 is going to be re-rebased to deal with the (minor) conflict. That PR is also waiting on at least one followup comment.

  39. fanquake merged this on May 10, 2023
  40. fanquake closed this on May 10, 2023

  41. maflcko deleted the branch on May 10, 2023
  42. sidhujag referenced this in commit b404e5b812 on May 10, 2023
  43. bitcoin locked this on May 9, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:53 UTC