lint: stop ignoring LIEF imports #27507

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:unignore_lief changing 6 files +6 −4
  1. fanquake commented at 9:32 AM on April 21, 2023: member

    Type stubs are now available as of 0.13.0. See https://github.com/lief-project/LIEF/issues/650.

  2. DrahtBot commented at 9:32 AM on April 21, 2023: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK TheCharlatan

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    No conflicts as of last run.

  3. fanquake commented at 9:40 AM on April 21, 2023: member

    ERROR: Could not find a version that satisfies the requirement lief==0.13.0 (from versions: 0.8.0.post7, 0.8.1.post1, 0.8.2.post1, 0.8.3.post3, 0.9.0, 0.10.0, 0.10.1, 0.11.0, 0.11.1, 0.11.2, 0.11.3, 0.11.4, 0.11.5, 0.12.0, 0.12.1, 0.12.2, 0.12.3) ERROR: No matching distribution found for lief==0.13.0

    Looks like LIEF 0.13.0 requires 3.8+, which is why this is failing to install. Guess this will be solved after #27483.

  4. maflcko cross-referenced this on Apr 21, 2023 from issue Bump python minimum version to 3.8 by maflcko
  5. DrahtBot added the label CI failed on Apr 21, 2023
  6. fanquake force-pushed on Apr 21, 2023
  7. fanquake commented at 2:32 PM on April 21, 2023: member

    Put on top of #27483.

  8. fanquake marked this as a draft on Apr 21, 2023
  9. DrahtBot cross-referenced this on Apr 22, 2023 from issue Introduce secp256k1 module with field and group classes to test framework by sipa
  10. DrahtBot cross-referenced this on Apr 22, 2023 from issue build: Add CMake-based build system by hebasto
  11. DrahtBot cross-referenced this on Apr 22, 2023 from issue test: add python implementation of Elligator swift by stratospher
  12. fanquake referenced this in commit d89aca1bdb on Apr 28, 2023
  13. maflcko added the label Needs rebase on Apr 28, 2023
  14. maflcko commented at 12:14 PM on April 28, 2023: member 
    contrib/devtools/security-check.py:246: error: "object" has no attribute "header"  [attr-defined]
  15. DrahtBot removed the label Needs rebase on Apr 28, 2023
  16. DrahtBot cross-referenced this on Apr 28, 2023 from issue test: Remove modinv python util helper function by fjahr
  17. fanquake force-pushed on May 1, 2023
  18. fanquake commented at 1:42 PM on May 1, 2023: member

    contrib/devtools/security-check.py:246: error: "object" has no attribute "header" [attr-defined]

    The script is working as expected. This seems to either be a bug in mypy, or an issue with the LIEF stubs. Am following up.

  19. fanquake commented at 8:28 AM on May 3, 2023: member

    or an issue with the LIEF stubs. Am following up.

    This has now been resolved upstream in LIEF. See https://github.com/lief-project/LIEF/issues/909 & https://github.com/lief-project/LIEF/commit/2e06bdb4af4586d1f5dcb9e9ccb027b55d457e24.

  20. hebasto commented at 7:47 PM on May 28, 2023: member

    or an issue with the LIEF stubs. Am following up.

    This has now been resolved upstream in LIEF. See lief-project/LIEF#909 & lief-project/LIEF@2e06bdb.

    LIEF 0.13.1 has just been released with the fix.

  21. lint: stop ignoring LIEF imports
    Type stubs are now available as of 0.13.0.
See https://github.com/lief-project/LIEF/issues/650.
    015cc5e588
  22. fanquake force-pushed on May 29, 2023
  23. fanquake marked this as ready for review on May 29, 2023
  24. fanquake commented at 9:27 AM on May 29, 2023: member

    Rebased and updated to use LIEF 0.13.1.

  25. DrahtBot removed the label CI failed on May 29, 2023
  26. fanquake requested review from TheCharlatan on May 29, 2023
  27. TheCharlatan approved
  28. TheCharlatan commented at 4:05 PM on May 29, 2023: contributor

    ACK 015cc5e588fa25f65f6ea2ed03701def8dfd5444

  29. fanquake merged this on May 29, 2023
  30. fanquake closed this on May 29, 2023
  31. fanquake deleted the branch on May 29, 2023
  32. hebasto commented at 5:22 PM on May 29, 2023: member

    Post-merge ACK 015cc5e588fa25f65f6ea2ed03701def8dfd5444.

  33. sidhujag referenced this in commit bc532b9581 on May 29, 2023
  34. hebasto cross-referenced this on Jun 3, 2023 from issue guix: Update `python-lief` package to 0.13.2 by hebasto
  35. fanquake referenced this in commit ec822e88dd on Jun 28, 2023
  36. sidhujag referenced this in commit 61be3dddfb on Jun 30, 2023
  37. knst referenced this in commit 63bea741ce on Oct 19, 2023
  38. knst referenced this in commit 09b8836dc0 on Oct 19, 2023
  39. PastaPastaPasta referenced this in commit 6e7b402fe9 on Oct 23, 2023
  40. bitcoin locked this on May 28, 2024
Contributors
fanquakeDrahtBotmaflckohebastoTheCharlatan
Linked (view graph)
#27483 Bump python minimum version to 3.8#27813 guix: Update `python-lief` package to 0.13.2
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:53 UTC