ci: Remove second user account #27376

1. 
   maflcko commented at 6:32 AM on March 31, 2023: member

   The rationale for the second (nonroot) account no longer applies. See also #27333 (review)

2. ci: Remove second user account fafe3a8e38
3. 
   DrahtBot commented at 6:32 AM on March 31, 2023: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	josibake

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. DrahtBot added the label Tests on Mar 31, 2023
5. maflcko cross-referenced this on Mar 31, 2023 from issue ci: cleanup of CI_EXEC & CI_EXEC_ROOT by vstoyanov
6. josibake approved
7. 
   josibake commented at 6:41 AM on March 31, 2023: member

   utACK https://github.com/bitcoin/bitcoin/pull/27376/commits/fafe3a8e38bdb6d12b2654b066b8036ba3e9455d

8. 
   maflcko commented at 7:59 AM on March 31, 2023: member

   red CI can be ignored

9. fanquake requested review from hebasto on Mar 31, 2023
10. fanquake merged this on Mar 31, 2023
11. fanquake closed this on Mar 31, 2023

    ---

12. maflcko deleted the branch on Mar 31, 2023
13. sidhujag referenced this in commit 2a0e25d275 on Apr 1, 2023
14. 
    hebasto commented at 6:55 PM on April 4, 2023: member

    Unfortunately, I've noticed a regression introduced in this PR.

    On Ubuntu 22.04, running FILE_ENV="./ci/test/00_setup_env_native_tidy.sh" ./ci/test_run_all.sh locally fails with

    ...
    IWYU edited 30 files on your behalf.
    
    warning: Not a git repository. Use --no-index to compare two paths outside a working tree
    usage: git diff --no-index [<options>] <path> <path>
    ...
    

15. 
    maflcko commented at 9:43 AM on April 5, 2023: member

    Unfortunately, I've noticed a regression introduced in this PR.

    It works for me on latest master locally and on my CI cluster. Please provide exact steps to reproduce, ideally starting from a fresh install of your Linux.

16. 
    josibake commented at 11:07 AM on April 5, 2023: member

    I was able to reproduce this locally on master by running:

    make distclean
    FILE_ENV="./ci/test/00_setup_env_native_tidy.sh" ./ci/test_run_all.sh
    

    I ssh'd into the container and found that the git diff command is failing due to dubious permissions, which I think ./ci/lint/docker-entrypoint.sh is supposed to fix with git config --global --add safe.directory /bitcoin? Seems like maybe that fix isn't working everywhere but we didn't catch it before because of the whole two users hack.

    I was able to get all the scripts to run after I ran git config --global --add safe.directory "*" inside the docker container, but I'm not sure where to put this in the ci scripts to make this work. Will poke around a bit more and try and open a PR. Curious if you have any insights, as well @MarcoFalke

17. 
    maflcko commented at 11:12 AM on April 5, 2023: member

    ./ci/lint/ ...

    The lint system is completely different from ./ci/test/.

18. 
    josibake commented at 11:14 AM on April 5, 2023: member

    The lint system is completely different from ./ci/test/.

    yeah, just realized there is no overlap. seems like we just need to apply the same fix the lint system is using in ./ci/test/ ?

19. 
    maflcko commented at 11:15 AM on April 5, 2023: member

    As for the fix, anything should be fine. git safe.directory, or restoring the chown, or fiddling with the rsync command.

20. 
    josibake commented at 11:16 AM on April 5, 2023: member

    As for the fix, anything should be fine. git safe.directory, or restoring the chown, or fiddling with the rsync command.

    cool, I'll open a PR

21. josibake cross-referenced this on Apr 5, 2023 from issue ci: fix git dubious permissions error by josibake
22. fanquake referenced this in commit 5a8bd45056 on Apr 6, 2023
23. sidhujag referenced this in commit 9d5a44baca on Apr 6, 2023
24. maflcko cross-referenced this on Jun 15, 2023 from issue test: Add unit & functional test coverage for blockstore by pinheadmz
25. pinheadmz referenced this in commit 357ccb4c85 on Jun 15, 2023
26. pinheadmz referenced this in commit e51113c03d on Jun 17, 2023
27. bitcoin locked this on Apr 4, 2024

Contributors

maflckoDrahtBotjosibakehebasto

Review Requested
hebasto