test: wallet_create_tx.py fix race #27318

pull furszy wants to merge 1 commits into bitcoin:master from furszy:2022_walletcreatetx_fix_race changing 1 files +1 −0

furszy commented at 7:48 PM on March 23, 2023: member

Fixes #27316

Because wallets are internally synchronized through the validation interface, and the interface dispatches events on a worker thread, it is possible for a transaction created by the first wallet to not arrive to the second wallet before the second wallet attempts to use one of its outputs. This is because we do not wait for the BroadcastTransaction callback during the wallet's "submit to mempool" process. To address this in the tests, we need to manually sync the validation queue.
DrahtBot commented at 7:48 PM on March 23, 2023: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK josibake, theStack

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
DrahtBot added the label Tests on Mar 23, 2023

Type	Reviewers
ACK	josibake, theStack

test: wallet_create_tx.py fix race

Because wallets are internally synchronized
through the validation interface, and the
interface dispatches events on a worker thread,
it is possible for a transaction created by the
first wallet to not arrive at the second wallet
before the second wallet attempts to use one of
its outputs. This is because we do not wait for
the BroadcastTransaction callback during the wallet's
"submit to mempool" process. To address this in the
tests, we need to sync the validation queue.

8aab5157c5

furszy force-pushed on Mar 23, 2023
ryanofsky cross-referenced this on Mar 23, 2023 from issue refactor, kernel: Decouple ArgsManager from blockstorage by TheCharlatan
furszy cross-referenced this on Mar 24, 2023 from issue wallet_create_tx.py "Not solvable pre-selected input" exception by ryanofsky
fanquake requested review from theStack on Mar 28, 2023
josibake commented at 1:58 PM on March 28, 2023: member

ACK https://github.com/bitcoin/bitcoin/pull/27318/commits/8aab5157c55249c9023ae4e9654f5d42aaa4f314
theStack approved
theStack commented at 2:13 PM on March 28, 2023: contributor

ACK 8aab5157c55249c9023ae4e9654f5d42aaa4f314
fanquake merged this on Mar 28, 2023
fanquake closed this on Mar 28, 2023
sidhujag referenced this in commit 13a44c77a4 on Mar 28, 2023
glozow cross-referenced this on Apr 3, 2023 from issue refactor (tidy): Fixes after enable-debug configure by TheCharlatan
furszy deleted the branch on May 27, 2023
bitcoin locked this on May 26, 2024

Contributors

Labels

Linked (view graph)

#27125 refactor, kernel: Decouple ArgsManager from blockstorage #27316 wallet_create_tx.py "Not solvable pre-selected input" exception #27353 refactor (tidy): Fixes after enable-debug configure

test: wallet_create_tx.py fix race #27318

Reviews