refactor, net processing: Avoid CNode::m_relays_txs usage #27270

1. 
   dergoegge commented at 5:32 PM on March 16, 2023: member

   CNode::m_relays_txs is meant to only be used for the eviction logic in net. TxRelay::m_relay_txs will hold the same value and is meant to be used on the application layer to determine if we will/should relay transactions to a peer.

   (Shameless plug: we should really better specify the interface for updating eviction data to avoid refactors like this in the future -> #25572)

2. [net processing] Use TxRelay::m_relay_txs over CNode::m_relays_txs 55c4795c57
3. 
   DrahtBot commented at 5:32 PM on March 16, 2023: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	MarcoFalke
   Concept ACK	sdaftuar

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   <!--174a7506f384e20aa4161008e828411d-->

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #25572 (refactor: Introduce EvictionManager and use it for the inbound eviction logic by dergoegge)
   • #25268 (refactor: Introduce EvictionManager by dergoegge)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. dergoegge cross-referenced this on Mar 16, 2023 from issue p2p: Fill reconciliation sets and request reconciliation (Erlay) by naumenkogs
5. DrahtBot cross-referenced this on Mar 17, 2023 from issue refactor: Introduce EvictionManager and use it for the inbound eviction logic by dergoegge
6. DrahtBot cross-referenced this on Mar 17, 2023 from issue refactor: Introduce EvictionManager by dergoegge
7. fanquake requested review from mzumsande on Mar 19, 2023
8. fanquake requested review from sdaftuar on Mar 19, 2023
9. glozow added the label Refactoring on Mar 23, 2023
10. 
    sdaftuar commented at 5:59 PM on April 10, 2023: member

    utACK

    CNode::m_relays_txs is meant to only be used for the eviction logic in net. TxRelay::m_relay_txs will hold the same value and is meant to be used on the application layer to determine if we will/should relay transactions to a peer. @dergoegge Thanks for mentioning this understanding -- I hadn't looked at this code in a while, but I agree with this and I think this is helpful for everyone to understand as we do more work in this module.

11. maflcko added the label P2P on Apr 11, 2023
12. 
    maflcko commented at 10:20 AM on April 11, 2023: member

    lgtm ACK 55c4795c5794c5c2f8a69b394b847413c9cfbe36

13. fanquake merged this on Apr 11, 2023
14. fanquake closed this on Apr 11, 2023

    ---

15. sidhujag referenced this in commit 4fe31e65c8 on Apr 11, 2023
16. bitcoin locked this on Apr 10, 2024

Contributors

dergoeggeDrahtBotsdaftuarmaflcko

Review Requested
sdaftuarmzumsande