wait_until_helper is a "private" helper, not intended to be used directly, because it doesn't scale the timeout with the timeout factor. Fix this by replacing it with a call to self.wait_until, which does the scaling.
test: Use self.wait_until over wait_until_helper #27226
pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2303-test-wait-self-🛩 changing 1 files +1 −1-
maflcko commented at 10:33 AM on March 8, 2023: member
-
test: Use self.wait_until over wait_until_helper faa671591f
-
DrahtBot commented at 10:33 AM on March 8, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- DrahtBot added the label Tests on Mar 8, 2023
- maflcko cross-referenced this on Mar 8, 2023 from issue Issue in `p2p_ibd_stalling.py` under Valgrind by fanquake
-
fanquake commented at 10:55 AM on March 8, 2023: member
Concept ACK. Will test under the CI
-
brunoerg commented at 5:41 PM on March 8, 2023: contributor
Concept ACK
-
- fanquake cross-referenced this on Mar 8, 2023 from issue Issue with `wallet_importdescriptors.py --descriptors` under valgrind by fanquake
- fanquake requested review from theStack on Mar 8, 2023
- theStack approved
-
theStack commented at 12:02 AM on March 10, 2023: contributor
Code-review ACK faa671591f9c83ef0fb5afea151a1907c28f024b
- fanquake merged this on Mar 10, 2023
- fanquake closed this on Mar 10, 2023
- maflcko deleted the branch on Mar 10, 2023
- sidhujag referenced this in commit 5928a8cf5a on Mar 10, 2023
- Fabcien referenced this in commit 41da7aa36f on Apr 3, 2023
- bitcoin locked this on Mar 9, 2024
