fuzz: avoid redundant dup key checks when creating Miniscript nodes #27117

1. 
   darosior commented at 11:42 AM on February 17, 2023: member

   I thought i had done that already in #24149, but it must have slipped through the rebase. It's a 2x speed improvement against the existing corpora and will probably be much more as we extend them with larger nodes.

2. fuzz: avoid redundant dup key checks when creating Miniscript nodes

   Check it only once on the top level node.
   
   Running libfuzzer with -runs=0 against the qa-assets corpus (1b9ddc96586769d92b1b62775f397b7f1a63f142).
   Without this patch:
   	miniscript_stable: Done 6616 runs in 118 second(s)
   	miniscript_smart: Done 13182 runs in 253 second(s)
   With this patch:
   	miniscript_stable: Done 6616 runs in 57 second(s)
   	miniscript_smart: Done 13182 runs in 124 second(s)

   c1b7bd047f
3. 
   DrahtBot commented at 11:42 AM on February 17, 2023: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	sipa

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. DrahtBot added the label Tests on Feb 17, 2023
5. 
   darosior commented at 11:43 AM on February 17, 2023: member

   cc @sipa

6. darosior cross-referenced this on Feb 17, 2023 from issue Signing support for Miniscript Descriptors by darosior
7. fanquake requested review from instagibbs on Feb 17, 2023
8. sipa cross-referenced this on Feb 21, 2023 from issue Improve miniscript_smart fuzz corpus by sipa
9. 
   sipa commented at 7:16 PM on February 21, 2023: member

   ACK c1b7bd047f47dcd3eb6897adfaf9a55594deff5d

   Ran fuzzing with miniscript_smart target, see https://github.com/bitcoin-core/qa-assets/pull/105.

10. fanquake merged this on Feb 22, 2023
11. fanquake closed this on Feb 22, 2023

    ---

12. sidhujag referenced this in commit 0603bdba60 on Feb 25, 2023
13. darosior cross-referenced this on Sep 26, 2023 from issue MiniTapscript: port Miniscript to Tapscript by darosior
14. bitcoin locked this on Feb 22, 2024

Contributors

darosiorDrahtBotsipa

Review Requested
instagibbs