Otherwise we'll just override other flags passed in (i.e msan).
Should fix https://cirrus-ci.com/task/6598922274078720?logs=ci#L3661.
depends: ensure we are appending to sqlite cflags #26998
pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:msan_flags_missing changing 1 files +1 −1-
fanquake commented at 5:15 PM on January 30, 2023: member
-
56a03f1834
depends: ensure we are appending to sqlite cflags
Otherwise we'll just override other flags passed in (i.e msan).
-
DrahtBot commented at 5:15 PM on January 30, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK TheCharlatan, achow101 If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- DrahtBot added the label Build system on Jan 30, 2023
- fanquake cross-referenced this on Jan 30, 2023 from issue MSan CI failure in psbt_wallet_tests and feebumper_tests by jonatack
- jonatack cross-referenced this on Jan 30, 2023 from issue Add pool based memory resource by martinus
- jonatack cross-referenced this on Jan 30, 2023 from issue A few follow-ups to #17487 (coins write without cache drop) by sipa
- fanquake marked this as ready for review on Jan 30, 2023
- TheCharlatan approved
-
TheCharlatan commented at 9:27 PM on January 30, 2023: contributor
ACK 56a03f1834a7437e3357923a1e45e512c9b2e6fc
Also checked that this is done correctly for the other
$(package)_*flags. -
achow101 commented at 9:57 PM on January 30, 2023: member
ACK 56a03f1834a7437e3357923a1e45e512c9b2e6fc
- achow101 merged this on Jan 30, 2023
- achow101 closed this on Jan 30, 2023
- sidhujag referenced this in commit f1fb1730a4 on Jan 30, 2023
- fanquake deleted the branch on Jan 31, 2023
- bitcoin locked this on Jan 31, 2024
