Fixes #22189.
The static std::multimap<uint256, FlatFilePos> mapBlocksUnknownParent; referenced in the issue was already fixed by #25571. I don't believe Chainstate references any other static variables.
Make static nLastFlush and nLastWrite Chainstate members #26513
pull aureleoules wants to merge 1 commits into bitcoin:master from aureleoules:2022-11-remove-static-chainstate changing 2 files +11 −10-
aureleoules commented at 4:56 PM on November 16, 2022: member
-
Make static nLastFlush and nLastWrite Chainstate members 07dfbb5bb8
-
DrahtBot commented at 3:32 AM on November 17, 2022: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
No conflicts as of last run.
- DrahtBot cross-referenced this on Nov 17, 2022 from issue assumeutxo: background validation completion by jamesob
- DrahtBot cross-referenced this on Nov 17, 2022 from issue assumeutxo by jamesob
-
jamesob commented at 3:21 PM on November 18, 2022: member
Concept ACK!
-
jamesob commented at 4:17 PM on November 18, 2022: member
ACK 07dfbb5bb8115c680621f361c65d9cde2f8c52f2 (
jamesob/ackr/26513.1.aureleoules.make_static_nlastflush_a)Reviewed, built, ran tests locally. Very simple, common-sense change that should be done. Thanks!
- theStack approved
-
theStack commented at 3:29 PM on December 7, 2022: contributor
Concept and code-review ACK 07dfbb5bb8115c680621f361c65d9cde2f8c52f2
-
jamesob commented at 4:39 PM on December 7, 2022: member
RFM?
- fanquake merged this on Dec 8, 2022
- fanquake closed this on Dec 8, 2022
- sidhujag referenced this in commit f3bf704897 on Dec 8, 2022
- aureleoules deleted the branch on Jan 12, 2023
- Fabcien referenced this in commit 6842022c60 on Dec 18, 2023
- bitcoin locked this on Jan 12, 2024
