build: Fix Boost.Process detection on macOS arm64 #24521

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:220310-boost changing 1 files +3 −0

hebasto commented at 12:08 PM on March 10, 2022: member

Could be tested as follows:

% brew install boost@1.76
% ./autogen.sh
% ./configure --with-boost='/opt/homebrew/opt/boost@1.76'

build: Fix Boost.Process detection on macOS arm64

Could be tested as follows:
```
% brew install boost@1.76
% ./autogen.sh
% ./configure --with-boost='/opt/homebrew/opt/boost@1.76'
```

1d4157a42b

fanquake added the label Build system on Mar 10, 2022
hebasto cross-referenced this on Mar 10, 2022 from issue Homebrew Boost 1.78 breaks external signer configure by Sjors
promag commented at 1:19 PM on March 10, 2022: member

Heh, I'll check this one. Any idea why it's different from x86_64?
hebasto commented at 1:24 PM on March 10, 2022: member

Heh, I'll check this one. Any idea why it's different from x86_64?

https://apple.stackexchange.com/questions/437618/why-is-homebrew-installed-in-opt-homebrew-on-apple-silicon-macs
promag commented at 9:45 PM on March 10, 2022: member

Tested ACK on 1d4157a42b77411579eb721b5c6fb533a357959d with boost 1.76 on macOS arm64. #24523 is required for boost 1.78.
DrahtBot cross-referenced this on Mar 11, 2022 from issue build: Fix Boost.Process test for Boost 1.78 by promag
DrahtBot commented at 6:18 AM on March 11, 2022: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #24523 (build: Fix Boost.Process test for Boost 1.78 by promag)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
hebasto commented at 8:01 AM on March 11, 2022: member

~As we have boost 1.77 in our depends, I think this should be backported into 23.x before the final release.~
fanquake merged this on Mar 11, 2022
fanquake closed this on Mar 11, 2022
hebasto deleted the branch on Mar 11, 2022
sidhujag referenced this in commit 8f466748fa on Mar 11, 2022
hebasto cross-referenced this on Mar 31, 2022 from issue 23.x backports by jonatack
jonatack referenced this in commit 26c2f23f36 on Mar 31, 2022
jonatack commented at 8:57 AM on March 31, 2022: contributor

Backported to v23 in #24512.
fanquake referenced this in commit c243e08351 on Mar 31, 2022
Sjors cross-referenced this on May 10, 2022 from issue Add external signer taproot support by Sjors
bitcoin locked this on Mar 31, 2023

Contributors

Labels

Linked (view graph)

#23578 Add external signer taproot support #24413 Homebrew Boost 1.78 breaks external signer configure #24512 23.x backports #24523 build: Fix Boost.Process test for Boost 1.78

build: Fix Boost.Process detection on macOS arm64 #24521

Conflicts