Add external signer taproot support #23578

pull Sjors wants to merge 1 commits into bitcoin:master from Sjors:2021/11/taproot_signer changing 3 files +21 −7
  1. Sjors commented at 3:16 PM on November 23, 2021: member

    Builds on #22558 (merged on 2022-06-28).

    HWI 2.1.0 or newer is required to import and use taproot descriptors. Older versions will work, but won't import a taproot descriptor.

    Tested with HWI 2.1.1:

    • Trezor T (firmware v2.5.1) on Signet: signs, change detection works
    • Ledger Nano S (firmware 2.1.0, Bitcoin app 2.0.6): signs, change detection works

    Only the most basic tr(key) descriptor is supported, script path spending is completely untested (if it works at all).

  2. DrahtBot added the label Descriptors on Nov 23, 2021
  3. DrahtBot added the label RPC/REST/ZMQ on Nov 23, 2021
  4. DrahtBot added the label Wallet on Nov 23, 2021
  5. DrahtBot commented at 6:07 PM on November 23, 2021: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #24313 (Improve display address handling for external signer by Sjors)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  6. DrahtBot cross-referenced this on Nov 23, 2021 from issue wallet: Avoid underpaying transaction fees when signing taproot spends by achow101
  7. DrahtBot cross-referenced this on Nov 23, 2021 from issue Replace MakeSpan helper with Span deduction guide by sipa
  8. DrahtBot cross-referenced this on Nov 23, 2021 from issue wallet: Automatically add receiving destinations to the address book by S3RK
  9. DrahtBot cross-referenced this on Nov 24, 2021 from issue psbt: Actually use SIGHASH_DEFAULT for PSBT signing by achow101
  10. DrahtBot cross-referenced this on Nov 24, 2021 from issue rpc: Allow walletprocesspsbt to sign without finalizing by achow101
  11. DrahtBot cross-referenced this on Nov 24, 2021 from issue wallet: allow toggling external_signer flag by Sjors
  12. DrahtBot cross-referenced this on Nov 24, 2021 from issue Implement BIP 370 PSBTv2 by achow101
  13. DrahtBot cross-referenced this on Nov 24, 2021 from issue [BIP 174] PSBT version, proprietary, and xpub fields by achow101
  14. DrahtBot cross-referenced this on Nov 24, 2021 from issue Avoid unnecessary signing provider copies on descriptor expansion by Empact
  15. DrahtBot cross-referenced this on Nov 25, 2021 from issue psbt: Taproot fields for PSBT by achow101
  16. DrahtBot cross-referenced this on Nov 27, 2021 from issue wallet: Split stuff from rpcwallet by maflcko
  17. DrahtBot added the label Needs rebase on Dec 13, 2021
  18. Sjors force-pushed on Dec 30, 2021
  19. DrahtBot removed the label Needs rebase on Dec 30, 2021
  20. DrahtBot cross-referenced this on Jan 4, 2022 from issue doc: Mark proprietary array optional by maflcko
  21. DrahtBot cross-referenced this on Jan 12, 2022 from issue Add (sorted)multi_a descriptor for k-of-n multisig inside tr by sipa
  22. DrahtBot cross-referenced this on Jan 24, 2022 from issue Deprecate SubtractFeeFromOutputs by achow101
  23. DrahtBot cross-referenced this on Jan 26, 2022 from issue Signing support for Miniscript Descriptors by darosior
  24. DrahtBot cross-referenced this on Feb 11, 2022 from issue Improve display address handling for external signer by Sjors
  25. DrahtBot added the label Needs rebase on Mar 4, 2022
  26. Rspigler cross-referenced this on Apr 18, 2022 from issue Awesome multisig PR labyrinth guide by Sjors
  27. Sjors commented at 1:35 PM on May 10, 2022: member

    Rebased, but won't work yet.

  28. Sjors force-pushed on May 10, 2022
  29. Sjors force-pushed on May 10, 2022
  30. Sjors marked this as ready for review on May 10, 2022
  31. Sjors commented at 2:37 PM on May 10, 2022: member

    Updated the external signer code to also look for fingerprints in input.m_tap_bip32_paths, so now it works.

  32. DrahtBot removed the label Needs rebase on May 10, 2022
  33. DrahtBot added the label Needs rebase on May 18, 2022
  34. Sjors force-pushed on May 20, 2022
  35. DrahtBot removed the label Needs rebase on May 20, 2022
  36. Sjors force-pushed on Jun 27, 2022
  37. wallet: add taproot support to external signer 796b020c37
  38. Sjors force-pushed on Jun 28, 2022
  39. Sjors commented at 3:16 PM on June 28, 2022: member

    Hooray, #22558 was merged, so this is now just one commit on top of master.

  40. jb55 commented at 3:34 PM on June 28, 2022: contributor

    utACK 796b020c37c793674f9d614d5d70fd1ed65f0938

  41. Sjors cross-referenced this on Sep 6, 2022 from issue devices/bitbox02: add taproot keypath spending support for bitbox02 by Beerosagos
  42. Sjors cross-referenced this on Sep 6, 2022 from issue Taproot support by Sjors
  43. achow101 commented at 10:54 PM on October 25, 2022: member

    ACK 796b020c37c793674f9d614d5d70fd1ed65f0938

  44. fanquake merged this on Oct 26, 2022
  45. fanquake closed this on Oct 26, 2022
  46. Sjors deleted the branch on Oct 26, 2022
  47. sidhujag referenced this in commit b2fd8cd7be on Oct 27, 2022
  48. bitcoin locked this on Oct 26, 2023
Contributors
SjorsDrahtBotjb55achow101
Labels
WalletRPC/REST/ZMQDescriptors
Linked (view graph)
#22558 psbt: Taproot fields for PSBT#24521 build: Fix Boost.Process detection on macOS arm64#24861 Awesome multisig PR labyrinth guide#25019 parse external signer master fp as bytes in ExternalSigner::SignTransaction
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:53 UTC