This PR is split from #21463.
The change was suggested on Transifex.com, and it does not touch LogPrint and LogPrintf calls.
The only comment on #21463 was:
Mind that these messages also end up in the log. In principle the log is already UTF-8 (as are all strings and text in bitcoind). But, just noting, that it might make browsing the log a less pleasant experience on systems with misconfigured locale like some BSDs by default.
-BEGIN VERIFY SCRIPT-
sed -i -E -e 's/\.\.\."\)(\.|,|\)| )/…"\)\1/' -- $(git ls-files -- 'src' ':(exclude)src/qt/bitcoinstrings.cpp')
sed -i -e 's/\.\.\.\\"/…\\"/' src/qt/sendcoinsdialog.cpp
sed -i -e 's|\.\.\.</string>|…</string>|' src/qt/forms/*.ui
sed -i -e 's|\.\.\.)</string>|…)</string>|' src/qt/forms/sendcoinsdialog.ui
-END VERIFY SCRIPT-
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
Concept ACK, it's much nicer!
Went line by line and it looks correct to me.
ACK d66f283ac07edce432b964f7f814631f5a5bc33b We do want to do an English translation update after this to prevent people from wasting time translating the old messages.
and it does not touch LogPrint and LogPrintf calls.
Still, InitMessages end up in the log. I don't see it as a blocking issue if no one else does though my comment was just a remark.
What are the benefits of this? Just looking nicer (which is discutable too)?
What are the benefits of this? Just looking nicer (which is discutable too)?
For many people there will be zero benefit. It depends on audience. Either you care about typography or you don't.
Anyway, when I open randomly a few applications on my computer, ellipses are used in dialogs and menus often so Bitcoin Core will look like other applications do which is a good thing I think.
What are the benefits of this? Just looking nicer (which is discutable too)?
As stated in the pr description, this change was suggested by translators on Transifex.com (you could see open issues there).
I personally did not make any research on this topic. I assume that translators could be more experienced than me on it :)
It just seems to be the way to do it nowadays (in the age of unicode). It's intended as ELLIPSIS, there's a dedicated character for it which is better than using three separate dots. This means the rendering engine has more meta-information about how to display it. It's definitely a very minor thing though and if it becomes controversial in the least we should close this.
Edit: I guess for accessibility it is also marginally important as a hint, instead of <dot> <dot> <dot> the text to speech can interpret it semantically.