doc: Address feedback from Transifex translator community #21463

 236 | @@ -237,7 +237,7 @@ void PaymentServer::handleURIOrFile(const QString& s)
 237 |                          Q_EMIT message(tr("URI handling"),
 238 |                              tr("Cannot process payment request because BIP70 is not supported.")+
 239 |                              tr("Due to widespread security flaws in BIP70 it's strongly recommended that any merchant instructions to switch wallets be ignored.")+
 240 | -                            tr("If you are receiving this error you should request the merchant provide a BIP21 compatible URI."),
 241 | +                            tr("If you are receiving this error, you should request from the merchant to provide a BIP21 compatible URI."),

laanwj commented at 8:24 PM on March 18, 2021:

I don't think we should be making people re-translate the BIP70 deprecation message (another case below).

 140 | @@ -141,7 +141,7 @@ void PSBTOperationsDialog::saveTransaction() {
 141 |      filename_suggestion.append(".psbt");
 142 |      QString filename = GUIUtil::getSaveFileName(this,
 143 |          tr("Save Transaction Data"), filename_suggestion,
 144 | -        tr("Partially Signed Transaction (Binary)", "Name of binary PSBT file format") + QLatin1String(" (*.psbt)"), &selected_filter);
 145 | +        tr("Partially Signed Bitcoin Transaction (Binary)", "Name of binary PSBT file format") + QLatin1String(" (*.psbt)"), &selected_filter);

laanwj commented at 8:26 PM on March 18, 2021:

-0 on adding "Bitcoin" everywhere here, as this is bitcoin-only software and we only have one type of transaction, the bitcoin transaction, I think the context is already pretty clear?

  14 | @@ -15,7 +15,7 @@
  15 |  BanMan::BanMan(fs::path ban_file, CClientUIInterface* client_interface, int64_t default_ban_time)
  16 |      : m_client_interface(client_interface), m_ban_db(std::move(ban_file)), m_default_ban_time(default_ban_time)
  17 |  {
  18 | -    if (m_client_interface) m_client_interface->InitMessage(_("Loading banlist...").translated);
  19 | +    if (m_client_interface) m_client_interface->InitMessage(_("Loading banlist…").translated);

laanwj commented at 8:29 PM on March 18, 2021:

Mind that these messages also end up in the log. In principle the log is already UTF-8 (as are all strings and text in bitcoind). But, just noting, that it might make browsing the log a less pleasant experience on systems with misconfigured locale like some BSDs by default.