build: `make deploy` fails on macOS Big Sur 11.1 #20878

issue hebasto opened this issue on January 7, 2021

hebasto commented at 7:41 PM on January 7, 2021: member

% make deploy
Making all in src
Making all in doc/man
make[1]: Nothing to be done for `all'.
make[1]: Nothing to be done for `all-am'.
build-aux/install-sh -c -d Bitcoin-Qt.app/Contents/MacOS
STRIPPROG="/usr/bin/strip" /bin/sh /Users/hebasto1/bitcoin/build-aux/install-sh -c -s  ./src/qt/bitcoin-qt Bitcoin-Qt.app/Contents/MacOS/Bitcoin-Qt
/usr/local/bin/python3.9 ./contrib/macdeploy/macdeployqtplus Bitcoin-Qt.app Bitcoin-Core -translations-dir= -dmg
Traceback (most recent call last):
  File "/Users/hebasto1/bitcoin/./contrib/macdeploy/macdeployqtplus", line 22, in <module>
    from ds_store import DSStore
ModuleNotFoundError: No module named 'ds_store'
make: *** [Bitcoin-Core.dmg] Error 1

hebasto added the label Bug on Jan 7, 2021
hebasto commented at 8:00 PM on January 7, 2021: member

It is easy fixed by pip3 install ds_store. The question is: is this a documentation flaw or a bug in the Makefile.am?
jonasschnelli commented at 8:16 PM on January 7, 2021: contributor

AFAIK there are more issue like the svg conversion tool... I went down that rabbit hole but couldn't find an exit. A fix would be great.
hebasto commented at 8:41 PM on January 7, 2021: member
@jonasschnelli

A fix would be great.

There are to ways:
1. update our docs with pip3 install ds_store step, or
2. or add OSX_DEPLOY_SCRIPT target to Makefile.am
is this a documentation flaw or a bug in the Makefile.am?
awesome-doge cross-referenced this on Jan 8, 2021 from issue Add macOS ARM build (universal or additional binaries) by jonasschnelli
hebasto cross-referenced this on Jan 8, 2021 from issue doc: Add explicit macdeployqtplus dependencies install step by hebasto
fanquake closed this on Jan 10, 2021
sidhujag referenced this in commit 1cd3c7b845 on Jan 10, 2021
hebasto commented at 5:02 PM on March 16, 2022: member

@otech47

Does #20878 (comment) work for you?

Could you make another try in a new Terminal window?
otech47 commented at 5:06 PM on March 16, 2022: none

@otech47

Does #20878 (comment) work for you?

Sorry @hebasto I quickly deleted my comment to see if there was something in this doc that may help before re-posting but no pip3 install ds_store did not work

Comment was:

I'm still seeing this error after following the build guide

There may be an extra command/config I need that maybe could be added to the documentation... will try to figure it out
hebasto commented at 5:11 PM on March 16, 2022: member

Sorry @hebasto I quickly deleted my comment to see if there was something in this doc that may help before re-posting but no pip3 install ds_store did not work

Could you make another try in a new Terminal window?
otech47 commented at 5:16 PM on March 16, 2022: none

Could you make another try in a new Terminal window?

No luck unfortunately
hebasto commented at 5:19 PM on March 16, 2022: member

@otech47

Please provide system details (arch, os) including the way python itself has been installed.
Dunya-8a commented at 6:49 PM on April 14, 2022: none

@hebasto I'm having the same issue. Running on a Macbook Pro, Monterey 12.3. I installed python via brew as specified in the MacOS build docs but I also have an installation via conda (which is currently not working in my editor I should say). However, I just ran python -version and it gives me python not found. Odd.

Also I installed the required dependencies (ds_store and mac_alias) with pip3.

Any thoughts?
kmdarshan commented at 5:26 PM on July 7, 2022: none

I noticed deleting the old installation of ds_store, and reinstalling worked.
bitcoin locked this on Jul 7, 2023

Contributors

Labels

Linked (view graph)

#20371 Add macOS ARM build (universal or additional binaries)#20890 doc: Add explicit macdeployqtplus dependencies install step