Do not expose and consider -logthreadnames when it does not work #18665

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:200416-logthreads changing 1 files +6 −0

hebasto commented at 12:32 PM on April 16, 2020: member
There are conditions when the HAVE_THREAD_LOCAL macro is undefined what causes the -logthreadnames option does not work -- instead of thread names empty strings [] only are printed in the debug.log file.

This PR does not exposes the -logthreadnames option in such cases.

Refs:
- #16059
- #18652
hebasto cross-referenced this on Apr 16, 2020 from issue 0.20.0rc1: Broken -logthreadnames on gitian builds by hebasto
fanquake added the label Utils/log/libs on Apr 16, 2020
laanwj commented at 1:14 PM on April 16, 2020: member

ACK 2ea5807fd36391e8f3b03c883066666132cfcb69

I'd prefer the option to just work in gitian builds, but this is a good and simple workaround.
MarcoFalke commented at 10:04 AM on April 20, 2020: member

Can you explain how the patch is supposed to work? Making an argument hidden in the help does not at all influence how it is parsed. The [] are still printed
Do not expose and consider -logthreadnames when it does not work b91e4ae0d8
hebasto force-pushed on Apr 20, 2020
hebasto commented at 11:29 AM on April 20, 2020: member
Updated 2ea5807fd36391e8f3b03c883066666132cfcb69 -> b91e4ae0d8ab2ae6b77585c97c52d825f56ed539 (pr18665.01 -> pr18665.02, diff):
- addressed @MarcoFalke's comment
Can you explain how the patch is supposed to work? Making an argument hidden in the help does not at all influence how it is parsed. The [] are still printed
hebasto renamed this:
~~Do not expose -logthreadnames when it does not work~~
Do not expose and consider -logthreadnames when it does not work
on Apr 20, 2020
MarcoFalke commented at 11:34 AM on April 20, 2020: member

ACK b91e4ae0d8ab2ae6b77585c97c52d825f56ed539, looked at the diff, didn't test
laanwj merged this on Apr 22, 2020
laanwj closed this on Apr 22, 2020
laanwj added the label Needs backport (0.20) on Apr 22, 2020
hebasto deleted the branch on Apr 22, 2020
sidhujag referenced this in commit 36106e9ef0 on Apr 23, 2020
fanquake referenced this in commit 54d2063d1a on Apr 23, 2020
fanquake cross-referenced this on Apr 23, 2020 from issue [0.20] rc2 Backports by fanquake
fanquake removed the label Needs backport (0.20) on Apr 23, 2020
laanwj referenced this in commit fb5b098598 on May 11, 2020
backpacker69 referenced this in commit 0e4d52a322 on Mar 28, 2021
Fabcien referenced this in commit fc59a386f9 on Aug 24, 2021
bitcoin locked this on Feb 15, 2022

Contributors

Labels

Linked (view graph)

#16059 configure: Fix thread_local detection #18652 0.20.0rc1: Broken -logthreadnames on gitian builds #18748 [0.20] rc2 Backports