util: Move ResolveErrMsg to util/error #16620

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:1908-utilErrorResolveErrMsg changing 4 files +13 −10

MarcoFalke commented at 2:08 PM on August 15, 2019: member

Pull request #16248 (review) duplicated the body of this util function. The whole point of the util function is to be shared, so do that here as a fixup to #16248
util: Move ResolveErrMsg to util/error fa27c55b05
MarcoFalke added the label Refactoring on Aug 15, 2019
MarcoFalke cross-referenced this on Aug 15, 2019 from issue Make whitebind/whitelist permissions more flexible by NicolasDorier
Sjors commented at 2:13 PM on August 15, 2019: member

utACK fa27c55
DrahtBot commented at 8:03 PM on August 15, 2019: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #16224 (gui: Bilingual GUI error messages by hebasto)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
in src/init.cpp:825 in fa27c55b05
```
 821 | @@ -822,11 +822,6 @@ void InitParameterInteraction()
 822 |      }
 823 |  }
 824 |  
 825 | -static std::string ResolveErrMsg(const char * const optname, const std::string& strBind)
```
promag commented at 11:36 PM on August 15, 2019:

Shoud #include <util/error.h> then?

MarcoFalke commented at 11:52 AM on August 16, 2019:

Will leave as is for now to not invalidate review
NicolasDorier commented at 4:27 AM on August 16, 2019: contributor

utACK seems like travis need a kick-in-the-box (and maybe need #16620 (review))
ryanofsky approved
ryanofsky commented at 10:54 AM on August 16, 2019: contributor

utACK fa27c55b0593c769b6ad87de0b59df3816d73548
MarcoFalke merged this on Aug 16, 2019
MarcoFalke closed this on Aug 16, 2019
MarcoFalke referenced this in commit 21a165325e on Aug 16, 2019
hebasto cross-referenced this on Aug 17, 2019 from issue gui: Bilingual GUI error messages by hebasto
deadalnix referenced this in commit 35f36b8ef1 on Jul 28, 2020
bitcoin locked this on Dec 16, 2021

Contributors

Labels

Linked (view graph)

#16224 gui: Bilingual GUI error messages #16248 Make whitebind/whitelist permissions more flexible

util: Move ResolveErrMsg to util/error #16620

Conflicts