trivial: Removes unsed `CBloomFilter` constructor. #13948

pull l2a5b1 wants to merge 1 commits into bitcoin:master from l2a5b1:patch/remove-private-cbloomfilter-contructor changing 2 files +0 −15

l2a5b1 commented at 11:28 PM on August 12, 2018: contributor

This pull request removes the CBloomFilter::CBloomFilter(const unsigned int, const double, const unsigned int) constructor, which became obsolete with 086ee67.

Removes unsed `CBloomFilter` constructor.

This commit removes the `CBloomFilter::CBloomFilter(const unsigned int, const double, const unsigned int)` constructor, which became obsolete with 086ee67.

265bd50884

fanquake added the label Refactoring on Aug 12, 2018
Empact commented at 1:15 AM on August 13, 2018: member

utACK 265bd50

nit: After this there are no references to BLOOM_UPDATE_NONE outside the tests. May be good to apply that here?: https://github.com/bitcoin/bitcoin/blob/0df7a6c13ec484f9f31cfe3ed3039098a9bef124/src/bloom.h#L71
practicalswift commented at 8:28 AM on August 13, 2018: contributor

utACK 265bd50884ac1984c08f0e5916256d5f12e655f5

Nice! How did you find this one?
domob1812 commented at 9:16 AM on August 13, 2018: contributor

utACK 265bd50884ac1984c08f0e5916256d5f12e655f5
fanquake commented at 2:14 AM on August 14, 2018: member

utACK 265bd50
laanwj commented at 8:58 AM on August 14, 2018: member

utACK 265bd50884ac1984c08f0e5916256d5f12e655f5
ken2812221 referenced this in commit db3cb5c5a6 on Aug 14, 2018
laanwj merged this on Aug 14, 2018
laanwj closed this on Aug 14, 2018
l2a5b1 commented at 2:54 PM on August 14, 2018: contributor

Thanks all! @Empact, that's a nice find. I like your suggestion and I would prefer BLOOM_UPDATE_NONE over value 0 as argument. @practicalswift, I bumped into this while going through friend class declarations.
l2a5b1 deleted the branch on Aug 14, 2018
Bushstar cross-referenced this on Sep 4, 2018 from issue commits from bitcoin/master by Bushstar
random-zebra cross-referenced this on Feb 5, 2021 from issue [Core] More efficient rolling Bloom filter by random-zebra
furszy referenced this in commit c5edef052e on Feb 14, 2021
str4d cross-referenced this on Mar 5, 2021 from issue Backport bloom filter improvements by str4d
zkbot referenced this in commit be459619a8 on Mar 5, 2021
zkbot referenced this in commit 78de0cdf46 on Apr 15, 2021
Munkybooty referenced this in commit fa607b1132 on Jun 27, 2021
Munkybooty referenced this in commit 7fedcf10bc on Jun 29, 2021
Munkybooty referenced this in commit 12eacdd389 on Jun 29, 2021
Munkybooty referenced this in commit 07ba57c97b on Jun 29, 2021
Munkybooty referenced this in commit 87251d8376 on Jun 29, 2021
Munkybooty referenced this in commit 8a47abd98b on Jun 30, 2021
bitcoin locked this on Sep 8, 2021

Contributors

Labels