fanquake
commented at 1:16 PM on July 8, 2018:
member
This is a rebased version of #13589 with the changes to the 0.16.x release notes removed.
#13004 changed the default behavior for printtoconsole but this has not been reflected in the command line help.
This fixes the description of -printtoconsole to reflect this change, and also provides the user with missing information on how to explicitly disable logging to debug.log.
At present I have made the latter update to two separate places (-printtoconsole and -debuglogfile) because a user looking for information on how to disable logging is probably going to look in the "Debugging/Testing Options" section. Moving -debuglogfile from the "General" options category to the "Debugging/Testing" section could potentially remove the need for this redundancy but may be out of the scope of this PR.
Fix command line help for -printtoconsole and -debuglogfile
#13004 changed the default behavior for printtoconsole but this has not been reflected in the command line help.
This fixes the description of -printtoconsole to reflect this change, and also provides the user with missing information on how to explicitly disable logging to debug.log.
At present I have made the latter update to two separate places (-printtoconsole and -debuglogfile) because a user looking for information on how to disable logging is probably going to look in the "Debugging/Testing Options" section. Moving -debuglogfile from the "General" options category to the "Debugging/Testing" section could potentially remove the need for this redundancy but may be out of the scope of this PR.
satwo
commented at 2:30 AM on July 9, 2018:
contributor
@promag I was going to say the same. I intended to move them to doc/release-notes.md per @laanwj 's suggestion; is there a way I could still do that?
practicalswift
commented at 1:11 PM on July 9, 2018:
contributor
ACK5e362c0cf0148d594c1e83edab0774b64e8ec754
laanwj renamed this: doc: Update command line help for -printtoconsole and -debuglogfile doc: Update command line help for -printtoconsole and -debuglogfile (satwo) on Jul 9, 2018
laanwj
commented at 2:59 PM on July 9, 2018:
member
utACK5e362c0cf0148d594c1e83edab0774b64e8ec754
@laanwj 's suggestion; is there a way I could still do that?
Yes, at this point I'd recommend to make a new PR—one that does the release notes update only.
laanwj merged this on Jul 9, 2018
laanwj closed this on Jul 9, 2018
laanwj referenced this in commit 17e9106c86 on Jul 9, 2018
satwo referenced this in commit 0de195933b on Jul 10, 2018
This is a metadata mirror of the GitHub repository
bitcoin/bitcoin.
This site is not affiliated with GitHub.
Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:55 UTC