Print to console by default when not run with -daemon #13004

1232 | -        // and because this needs to happen before any other debug.log printing
1233 | -        ShrinkDebugFile();
1234 | -    }
1235 | -
1236 |      if (fPrintToDebugLog) {
1237 | +        if (gArgs.GetBoolArg("-shrinkdebugfile", logCategories == BCLog::NONE)) {

laanwj commented at 2:56 PM on April 17, 2018:

Whoa - good catch to move this inside the if (fPrintToDebugLog)

  14 | @@ -15,21 +15,25 @@ def set_test_params(self):
  15 |          self.num_nodes = 1
  16 |          self.setup_clean_chain = True
  17 |  
  18 | +    def relative_log_path(self, name):
  19 | +        return os.path.join(self.nodes[0].datadir, "regtest", name)

MarcoFalke commented at 3:17 PM on April 17, 2018:

nit: IIRC datadir is absolute, so the relative in the method name is confusing.

  58 | @@ -55,6 +59,17 @@ def run_test(self):
  59 |          self.start_node(0, ["-debuglogfile=%s" % (invalidname)])
  60 |          assert os.path.isfile(os.path.join(invdir, "foo.log"))
  61 |  
  62 | +        # check that -nodebuglogfile disables logging
  63 | +        self.stop_node(0)
  64 | +        os.unlink(default_log_path)

MarcoFalke commented at 3:20 PM on April 17, 2018:

Nit: Could use the identical and more clear "remove", since unlink seems to be some unix specific thing, but we also run the tests on windows.

 825 |  {
 826 | -    fPrintToConsole = gArgs.GetBoolArg("-printtoconsole", false);
 827 | +    // Add newlines to the logfile to distinguish this execution from the last
 828 | +    // one; called before console logging is set up, so this is only sent to
 829 | +    // debug.log.
 830 | +    LogPrintf("\n\n\n\n\n");

jimpo commented at 5:12 PM on April 17, 2018:

Hmm, won't it print these newlines even if fPrintToDebugLog ends up being false?