Use nullptr instead of zero (0) as the null pointer constant.
The road towards nullptr (C++11) is split into two PRs:
NULL → nullptr is handled in PR #10483 (scripted)0 → nullptr is handled in PR #10645 (manual, this PR)By using the C++11 keyword nullptr we are guaranteed a prvalue of type std::nullptr_t.
For a more thorough discussion, see "A name for the null pointer: nullptr" (Sutter & Stroustrup), http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2007/n2431.pdf
utACK a0fbff2c8c0621d2ef4759078b3c690f1c33748b
Concept ACK
Rebased!
@laanwj Thanks for merging the NULL → nullptr PR (#10483). This PR handles the case 0 → nullptr and has now been rebased on top of master.
897 | @@ -898,7 +898,7 @@ class FormatListN : public FormatList 898 | // Special 0-arg version - MSVC says zero-sized C array in struct is nonstandard 899 | template<> class FormatListN<0> : public FormatList 900 | { 901 | - public: FormatListN() : FormatList(0, 0) {} 902 | + public: FormatListN() : FormatList(nullptr, 0) {}
Agree, we should generally minimize changes to tinyformat.h, and if it is just style it just adds burden on us with no clear gain.
If you get upstream to accept this it's okay with me. But I think they want to keep compatiblity with older C++.
Tested ACK f71710dad454f5afe431479d0aea578b36d68206. Looks good @practicalswift . Thanks for doing this!
One open question for @laanwj
