I claim the check can be removed but I don't want to touch this stable and well-tested code.
On the way, we fix grammar in another comment.
Add comment on length checks when parsing ECDSA sigs #990
pull real-or-random wants to merge 1 commits into bitcoin-core:master from real-or-random:202110-readlen-comment changing 1 files +4 −3-
real-or-random commented at 10:11 AM on October 17, 2021: contributor
-
e02f313b1f
Add comment on length checks when parsing ECDSA sigs
I claim the check can be removed but I don't want to touch this stable and well-tested code. On the way, we fix grammar in another comment.
-
sipa commented at 5:43 PM on May 11, 2023: contributor
ACK e02f313b1f251ccb363ae1ac24016d87c1be9009
- real-or-random added the label documentation on May 11, 2023
-
RandyMcMillan commented at 5:48 PM on May 11, 2023: none
ACK e02f313
- real-or-random removed the label user-documentation on Dec 7, 2023
- real-or-random added the label refactor/smell on Dec 7, 2023
-
real-or-random commented at 8:26 AM on December 7, 2023: contributor
Merging this because it's just a change in a comment. If we ever change the actual code, we should get more eyes on it.
- real-or-random merged this on Dec 7, 2023
- real-or-random closed this on Dec 7, 2023
- fanquake referenced this in commit 41e1b677ca on Jan 3, 2024
- fanquake referenced this in commit 29fde0223a on Jan 4, 2024
- janus referenced this in commit 5fe435c9b2 on Apr 6, 2024
- hebasto referenced this in commit b6de625950 on May 11, 2024
- delta1 referenced this in commit 6089844b3c on Apr 2, 2025
- div72 referenced this in commit af627d47c3 on Apr 12, 2025
- str4d referenced this in commit 136aa9fe62 on Jun 4, 2025
- oskarszoon referenced this in commit 0d5c9260f4 on Jul 1, 2025
Contributors
Labels