These functions do not modify their argument.
Make argument of fe_normalizes_to_zero{_var} const #903
pull sipa wants to merge 1 commits into bitcoin-core:master from sipa:202103_const_norm_to_zero changing 3 files +9 −10-
sipa commented at 6:34 PM on March 12, 2021: contributor
- apoelstra approved
-
apoelstra commented at 10:07 PM on March 12, 2021: contributor
ack 147494ce9975fea449381ec29af2e300dad2e7e2
-
peterdettman commented at 5:03 AM on March 13, 2021: contributor
As the method comments say, it can optionally normalize the value. I believe this had something to do with one of the field implementations at the time (openssl, gmp??) not really having a good option with a const argument. Don't recall. Presumably it is a redundant consideration now.
-
sipa commented at 5:25 AM on March 13, 2021: contributor
@peterdettman Ha, good point. At least the comments should be updated.
-
Make argument of fe_normalizes_to_zero{_var} const 23c3fb629b
- sipa force-pushed on Mar 15, 2021
-
sipa commented at 11:02 PM on March 15, 2021: contributor
Updated the function descriptions.
- real-or-random approved
-
real-or-random commented at 1:51 PM on March 16, 2021: contributor
ACK 23c3fb629b905deebc4bcc9914bcfff7b9aedacd diff looks good
-
jonasnick commented at 2:55 PM on March 26, 2021: contributor
ACK 23c3fb629b905deebc4bcc9914bcfff7b9aedacd
- jonasnick merged this on Mar 26, 2021
- jonasnick closed this on Mar 26, 2021
- Fabcien referenced this in commit acefaf2181 on Jan 6, 2026
- Fabcien referenced this in commit 90416814bc on Jan 6, 2026
Contributors