travis: Explicitly set --with-valgrind #821

pull jonasnick wants to merge 2 commits into bitcoin-core:master from jonasnick:travis-valgrind changing 2 files +7 −6

jonasnick commented at 9:14 AM on September 19, 2020: contributor

Also remove CPPFLAGS=-DVALGRIND because that's redundant with when configured with --enable-valgrind.

in .travis.yml:20 in 995b240f56 outdated

  16 | @@ -17,7 +17,7 @@ compiler:
  17 |    - gcc
  18 |  env:
  19 |    global:
  20 | -    - WIDEMUL=auto  BIGNUM=auto  ENDOMORPHISM=no  STATICPRECOMPUTATION=yes  ECMULTGENPRECISION=auto  ASM=no  BUILD=check  EXTRAFLAGS=  HOST=  ECDH=no  RECOVERY=no SCHNORRSIG=no EXPERIMENTAL=no CTIMETEST=yes BENCH=yes ITERS=2
  21 | +    - WIDEMUL=auto  BIGNUM=auto  ENDOMORPHISM=no  STATICPRECOMPUTATION=yes  ECMULTGENPRECISION=auto  ASM=no  BUILD=check  ENABLE_VALGRIND=yes RUN_VALGRIND=no EXTRAFLAGS=  HOST=  ECDH=no  RECOVERY=no SCHNORRSIG=no EXPERIMENTAL=no CTIMETEST=yes BENCH=yes ITERS=2

luke-jr commented at 3:42 PM on September 19, 2020:

Should it run valgrind to be sure it worked?

jonasnick commented at 7:43 AM on September 21, 2020:

It runs valgrind if RUN_VALGRIND is yes which happens in lines 39 and 40.

real-or-random commented at 8:11 AM on September 21, 2020:

ah sure, I missed that this is the global line

luke-jr commented at 3:42 PM on September 19, 2020: member

Nit: I think it would be better to rename VALGRIND in a separate commit
jonasnick force-pushed on Sep 21, 2020
jonasnick renamed this:
~~travis: Explicitly set --enable-valgrind and disable once~~
travis: Explicitly set --with-valgrind
on Sep 21, 2020
travis: Explicitly set --with-valgrind
Also set --with-valgrind=no once
66a765c775
jonasnick commented at 7:53 AM on September 21, 2020: contributor

Split into two commits.
jonasnick force-pushed on Sep 21, 2020

travis: VALGRIND->RUN_VALGRIND to avoid confusion with WITH_VALGRIND

Also remove CPPFLAGS=-DVALGRIND because that's redundant when
configured with --with-valgrind.

4eecb4d6ef

real-or-random commented at 1:23 PM on September 21, 2020: contributor

ACK 4eecb4d6ef6d4f18be8870a5929feb1dae376d15 diff and travis output look good
sipa commented at 3:38 AM on September 26, 2020: contributor

utACK 4eecb4d6ef6d4f18be8870a5929feb1dae376d15
elichai commented at 9:09 AM on September 26, 2020: contributor

ACK 4eecb4d6ef6d4f18be8870a5929feb1dae376d15
real-or-random merged this on Sep 26, 2020
real-or-random closed this on Sep 26, 2020
jasonbcox referenced this in commit 13ebc47995 on Sep 29, 2020
deadalnix referenced this in commit b96288b72b on Sep 30, 2020

Contributors