Check signature nonces for validity #8

pull swansontec wants to merge 1 commits into bitcoin-core:master from swansontec:master changing 1 files +10 −2

swansontec commented at 9:25 PM on April 24, 2014: contributor

The documentation implies that this check is happening, so make it so. Without this check, passing an invalid nonce will trigger an internal assertion.

I ran into this when I was unit-testing my C++ wrapper - the library threw an assertion instead of returning false as my test was expecting.

Check signature nonces for validity

The documentation implies that this check is happening, so make it so.
Without this check, passing an invalid nonce will trigger an internal assertion.

ba8fc0e28f

sipa merged this on May 8, 2014
sipa closed this on May 8, 2014
sipa referenced this in commit 78fb796997 on May 8, 2014
swansontec commented at 6:27 PM on May 8, 2014: contributor

Thanks!
sipa commented at 6:32 PM on May 8, 2014: contributor

Feel free to contribute your C++ wrapper, by the way.
swansontec commented at 6:39 PM on May 8, 2014: contributor

The C++ wrapper lives in libbitcoin at the moment, if you are interested in looking at it.
evoskuil referenced this in commit 18e729ecaa on Dec 30, 2021
real-or-random referenced this in commit 9a8db52f4e on Oct 29, 2024
real-or-random referenced this in commit ac561601b8 on Feb 19, 2026

Contributors

swansontec

sipa

Linked (view graph)

#52 arm/ios crash #1511 msan: use of uninitialized value in secp256k1_scalar_mul_shift_var #1582 cmake, test: Add `secp256k1_` prefix to test names #1760 cmake: Add dynamic test discovery to improve parallelism