secp256k1_fe_sqrt: Verify that the arguments don't alias. #551

pull roconnor-blockstream wants to merge 1 commits into bitcoin-core:master from roconnor-blockstream:sqrt changing 1 files +2 −0

roconnor-blockstream commented at 10:19 PM on August 14, 2018: contributor

No description provided.
secp256k1_fe_sqrt: Verify that the arguments don't alias. bf8b86cc07
roconnor-blockstream force-pushed on Aug 14, 2018
roconnor-blockstream renamed this:
~~secp256k1_fe_sqrt: Verify that the arguements don't alias.~~
secp256k1_fe_sqrt: Verify that the arguments don't alias.
on Aug 14, 2018

DesWurstes commented at 8:30 AM on September 2, 2018: contributor

Please change

static int secp256k1_fe_sqrt(secp256k1_fe *r, const secp256k1_fe *a)

static int secp256k1_fe_sqrt(secp256k1_fe *r, const secp256k1_fe * SECP256K1_RESTRICT a)

roconnor-blockstream commented at 4:26 PM on September 13, 2018: contributor

I think your requested amendment is a good idea. However, I do not currently have the energy to shepherd this PR. Maintainers have permission to edit this branch, otherwise you can fork this PR and continue with a new PR.
gmaxwell merged this on Feb 21, 2019
gmaxwell closed this on Feb 21, 2019
gmaxwell referenced this in commit 1c131affd3 on Feb 21, 2019
gmaxwell referenced this in commit 85d0e1bcce on Feb 24, 2019

Contributors