Some comments explaining some of the constants in the code. #206

pull gmaxwell wants to merge 2 commits into bitcoin-core:master from gmaxwell:constant_comments changing 9 files +40 −2

gmaxwell commented at 2:51 AM on February 2, 2015: contributor

No description provided.
droark commented at 4:16 AM on February 2, 2015: none

Thanks, Greg. I've been doing a review of libsecp256k1 in my free time. Comments like these and the one in pull request #205 are a huge help. :)

in src/ecdsa_impl.h:None in a90b05340b outdated

  14 | @@ -15,11 +15,28 @@
  15 |  #include "ecmult_gen.h"
  16 |  #include "ecdsa.h"
  17 |  
  18 | +/** Group order for secp256k1 defined as 'n' in "Standards for Efficient Cryptography" (SEC2) 2.7.1

sipa commented at 11:50 PM on February 6, 2015:

This prints p, not n.

sipa commented at 11:56 PM on February 6, 2015: contributor

There are several copies of p and n in different places of the code. Maybe it's useful to only explain them once, and just put references in other places ("see the definition of secp256k1_scalar_const_order in file X").
Some comments explaining some of the constants in the code. 6efd6e7777
Additional comments for the testing PRNG and a seeding fix.
Rw has additional short-cycle inputs because 2^32/0x464fffff >= 2.
34b898dc84
sipa commented at 12:26 AM on February 13, 2015: contributor

ACK
sipa merged this on Feb 13, 2015
sipa closed this on Feb 13, 2015
sipa referenced this in commit 035406d6db on Feb 13, 2015

Contributors

gmaxwell

droark

sipa