doc: clean up lingering ECMULT_WINDOW_SIZE comment #1946

pull Yudis-bit wants to merge 1 commits into bitcoin-core:master from Yudis-bit:doc-ecmult-window-size-comment changing 2 files +11 −11

Yudis-bit commented at 4:42 PM on September 27, 2026: contributor
The comment documenting the costs and precomputed table size of \ECMULT_WINDOW_SIZE\ in \src/ecmult_impl.h\ resided directly under #define WINDOW_A 5\ and referenced \WINDOW_G. This became lingering and out of context when \ecmult_context\ was removed in 6815761cf5500f1a619965c5b4bbc8918b334a35.
- Move the documentation comment to \src/ecmult.h\ directly preceding #ifndef ECMULT_WINDOW_SIZE.
- Use \ECMULT_TABLE_SIZE(ECMULT_WINDOW_SIZE)\ for the table size formula instead of referencing \WINDOW_G.
- Update the boundary comments (> 27\ and > 31) in \src/ecmult.h\ to refer to \ECMULT_WINDOW_SIZE\ rather than \WINDOW_G.
Closes #1766.

doc: clean up lingering ECMULT_WINDOW_SIZE comment

The comment documenting the costs and precomputed table size of ECMULT_WINDOW_SIZE in src/ecmult_impl.h was placed under the definition of WINDOW_A and referenced WINDOW_G, which became out of context since commit 6815761cf5500f1a619965c5b4bbc8918b334a35. Move the documentation comment to src/ecmult.h right above the definition of ECMULT_WINDOW_SIZE, format the table size using ECMULT_TABLE_SIZE, and update references to WINDOW_G in the boundary checks to ECMULT_WINDOW_SIZE. Closes #1766.

cc0e03ffd4

Yudis-bit requested review from Copilot on Sep 27, 2026
Copilot commented at 4:42 PM on September 27, 2026: none

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Contributors

Yudis-bit

Copilot

Linked (view graph)

#1766 Lingering comment documenting `ECMULT_WINDOW_SIZE` large values' costs