ecdsa: VERIFY_CHECK result of _fe_set_b32_limit #1839

pull real-or-random wants to merge 1 commits into bitcoin-core:master from real-or-random:202603-ecdsa-maybe-undef changing 1 files +10 −2

real-or-random commented at 4:00 PM on March 23, 2026: contributor

This also avoids a spurious -Wmaybe-uninitialized warning emitted by gcc 16 (snapshot) when compiling with -DDETERMINISTIC.

Alternative to #1838 by @mllwchrry who tried very a similar thing as this PR but couldn't convince the compiler. (The GCC snapshot is very annoying: a simple VERIFY_CHECK(secp256k1_fe_set_b32_limit(&xr, c)) doesn't do the trick. I found this variant here with a local store rather by accident.)

ecdsa: VERIFY_CHECK result of _fe_set_b32_limit

This also avoids a spurious "-Wmaybe-uninitialized" warning emitted by
gcc 16 (snapshot) when compiling with -DDETERMINISTIC.

43fca0ff55

real-or-random added the label tweak/refactor on Mar 23, 2026
mllwchrry commented at 2:51 PM on March 24, 2026: contributor

Good solution. I find it more robust since it verifies the range assumption rather than just zero-initializing. I'll close my PR.
mllwchrry commented at 10:40 AM on March 25, 2026: contributor

ACK 43fca0f I tested the fix with the extended CI coverage and everything succeeded.
theStack approved
theStack commented at 2:57 PM on March 25, 2026: contributor

utACK 43fca0ff5594c1f25ef0ce63556b2ed344282190
real-or-random merged this on Mar 25, 2026
real-or-random closed this on Mar 25, 2026
fanquake referenced this in commit dfc5233b8c on Mar 27, 2026
fanquake referenced this in commit dfd54c959e on Apr 9, 2026
real-or-random referenced this in commit 99fab529bd on Apr 23, 2026
vmta referenced this in commit 1ddc2f947f on Apr 26, 2026
vmta referenced this in commit 56c40fe100 on Apr 27, 2026

Contributors

Labels