ecmult: Document and test ng=NULL in ecmult #1834

pull real-or-random wants to merge 2 commits into bitcoin-core:master from real-or-random:202603-ecmult changing 3 files +28 −16
  1. real-or-random commented at 4:49 PM on March 3, 2026: contributor

    No description provided.

  2. real-or-random force-pushed on Mar 3, 2026
  3. real-or-random marked this as ready for review on Mar 3, 2026
  4. real-or-random added the label tweak/refactor on Mar 3, 2026
  5. real-or-random added the label assurance on Mar 3, 2026
  6. theStack approved
  7. theStack commented at 6:26 PM on March 10, 2026: contributor

    ACK 87160614f6fff769226ba2c781e325b46c7c55ec

    I was curious on whether there would be a speedup noticeable in _pubkey_tweak_mul with NULL used instead of secp256k1_scalar_zero (second commit), but it seems there isn't on my machine, according to a hacked together benchmark https://github.com/theStack/secp256k1/commit/b9d523b31c733758035658d5debdbbd98c2d505e. Still good to document and test for this.

  8. ecmult: Document and test ng=NULL in ecmult 7e68c0c88b
  9. eckey: Call ecmult with NULL instead of zero scalar 3a403639dc
  10. in src/tests.c:5491 in 87160614f6 
    5488 | @@ -5481,23 +5489,24 @@ static int test_ecmult_accumulate_cb(secp256k1_scalar* sc, secp256k1_ge* pt, siz
5489 |  
5490 |  static void test_ecmult_accumulate(secp256k1_sha256* acc, const secp256k1_scalar* x, secp256k1_scratch* scratch) {
5491 |      /* Compute x*G in 6 different ways, serialize it uncompressed, and feed it into acc. */
    real-or-random commented at 6:45 AM on March 11, 2026: 
        /* Compute x*G in 7 different ways, serialize it uncompressed, and feed it into acc. */
    real-or-random commented at 10:10 AM on March 11, 2026:

    fixed

  11. real-or-random force-pushed on Mar 11, 2026
  12. theStack approved
  13. theStack commented at 1:26 PM on March 11, 2026: contributor

    re-ACK 3a403639dc07e39aa6dc48fbcecfe3cb77f09770

  14. real-or-random merged this on Mar 11, 2026
  15. real-or-random closed this on Mar 11, 2026
  16. fanquake referenced this in commit 6458812af8 on Mar 17, 2026
  17. fanquake referenced this in commit 791949a724 on Mar 21, 2026
  18. fanquake referenced this in commit cffa9320f2 on Mar 23, 2026
  19. theStack referenced this in commit 994739fc33 on Mar 26, 2026
  20. fanquake referenced this in commit dfc5233b8c on Mar 27, 2026
  21. theStack referenced this in commit 0326234c51 on Apr 2, 2026
  22. fanquake referenced this in commit dfd54c959e on Apr 9, 2026
  23. real-or-random referenced this in commit 99fab529bd on Apr 23, 2026
  24. vmta referenced this in commit 1ddc2f947f on Apr 26, 2026
  25. vmta referenced this in commit 56c40fe100 on Apr 27, 2026
Contributors
real-or-randomtheStack
Labels
assurancetweak/refactor
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:52 UTC