This is a follow-up to #1774 (review)
It is pretty straightforward to remove ret and to just return either 0 or 1
refactor: remove ret from secp256k1_ec_pubkey_serialize #1784
pull kevkevinpal wants to merge 1 commits into bitcoin-core:master from kevkevinpal:refactorRemoveRetECPubkeySerialize changing 1 files +2 −3-
kevkevinpal commented at 9:12 PM on December 9, 2025: contributor
-
refactor: remove ret from secp256k1_ec_pubkey_serialize 3daab83a60
- real-or-random added the label tweak/refactor on Dec 10, 2025
- real-or-random approved
-
real-or-random commented at 7:38 AM on December 10, 2025: contributor
utACK 3daab83a6050805763da5ac9ebe8217d1965eb0c
- theStack approved
-
theStack commented at 1:34 PM on December 10, 2025: contributor
ACK 3daab83a6050805763da5ac9ebe8217d1965eb0c
(fwiw #1774 (review) suggested to return early if
_pubkey_loadfails, reducing the levels of indentations, but either way seems to be fine, and I haven't seen a strong preference for one approach over another in our codebase) - real-or-random merged this on Dec 10, 2025
- real-or-random closed this on Dec 10, 2025
- Eunovo referenced this in commit b065787ddb on Jan 19, 2026
- fanquake referenced this in commit c4c4e04ca1 on Jan 26, 2026
- fanquake referenced this in commit 2fccbea3c8 on Jan 27, 2026
- fjahr referenced this in commit 182197f98a on Jan 29, 2026
- fjahr referenced this in commit ea9a84ab3c on Jan 31, 2026
- fjahr referenced this in commit 23c2527f12 on Feb 8, 2026
- Sjors referenced this in commit d5660d3a13 on Feb 16, 2026
- github-actions[bot] referenced this in commit c3f80fff5f on Mar 1, 2026
- github-actions[bot] referenced this in commit 4aeff8400e on Mar 1, 2026
- github-actions[bot] referenced this in commit 5f15eb0c55 on Mar 1, 2026
- 0x000000000019d6689c085ae165831e934ff76 referenced this in commit d54574beca on Mar 2, 2026
- csjones referenced this in commit fb3e16af04 on Mar 2, 2026
- real-or-random referenced this in commit 459eab20f2 on Mar 3, 2026
- vmta referenced this in commit 1ddc2f947f on Apr 26, 2026
- vmta referenced this in commit 56c40fe100 on Apr 27, 2026
