ci: Use Python virtual environment in "x86_64-macos-native" job #1771

pull hebasto wants to merge 1 commits into bitcoin-core:master from hebasto:251107-python-env changing 1 files +7 −12
  1. hebasto commented at 2:20 PM on November 7, 2025: member

    Fixes #1768.

    This PR explicitly sets up a virtual environment instead of using uv, as suggested here, for the following reasons:

    1. It does not require granting a third-party action access to the repository.
    2. This approach is already used in other parts of the CI framework (it’s unclear why it was missed in #1359 in the first place).
  2. real-or-random added the label bug on Nov 7, 2025
  3. real-or-random added the label ci on Nov 7, 2025
  4. in .github/workflows/ci.yml:472 in d3ae054474
     468 | @@ -469,9 +469,14 @@ jobs:
     469 |          env: ${{ matrix.env_vars }}
     470 |          run: ./ci/ci.sh
     471 |  
     472 | -      - name: Symbol check
     473 | +      - &SYMBOL_CHECK
    


    real-or-random commented at 3:03 PM on November 7, 2025:

    nit:

          - &SYMBOL_CHECK_MACOS
    
    • because it's specific to macOS
    • avoid naming confusing with the env variable SYMBOL_CHECK

    hebasto commented at 3:21 PM on November 7, 2025:

    Thanks! Reworked per your feedback.

  5. real-or-random approved
  6. real-or-random commented at 3:05 PM on November 7, 2025: contributor

    utACK d3ae05447429d66b065ce3982fb0c5864c18bb53

    Let's wait for green.

    Thanks for fixing CI so quickly. :)

    I agree, that's simpler and does the job. I still think uv is a good idea for devs who want to run the script locally, but that's a different story then.

  7. ci: Use Python virtual environment in "x86_64-macos-native" job f252da7e6e
  8. hebasto force-pushed on Nov 7, 2025
  9. real-or-random approved
  10. real-or-random commented at 7:21 PM on November 7, 2025: contributor

    ACK f252da7e6e1bbd0082fd43c4ffabfa90abafb248

  11. real-or-random merged this on Nov 7, 2025
  12. real-or-random closed this on Nov 7, 2025

  13. hebasto deleted the branch on Nov 7, 2025
  14. Eunovo referenced this in commit d66ec60d1e on Dec 1, 2025
  15. Eunovo referenced this in commit b065787ddb on Jan 19, 2026
  16. fjahr referenced this in commit 9dfc70d432 on Jan 26, 2026
  17. fanquake referenced this in commit c4c4e04ca1 on Jan 26, 2026
  18. fanquake referenced this in commit 2fccbea3c8 on Jan 27, 2026
  19. Sjors referenced this in commit d5660d3a13 on Feb 16, 2026
  20. github-actions[bot] referenced this in commit c3f80fff5f on Mar 1, 2026
  21. github-actions[bot] referenced this in commit 4aeff8400e on Mar 1, 2026
  22. github-actions[bot] referenced this in commit 5f15eb0c55 on Mar 1, 2026
  23. 0x000000000019d6689c085ae165831e934ff76 referenced this in commit d54574beca on Mar 2, 2026
  24. csjones referenced this in commit fb3e16af04 on Mar 2, 2026
  25. real-or-random referenced this in commit 459eab20f2 on Mar 3, 2026
  26. vmta referenced this in commit 1ddc2f947f on Apr 26, 2026
  27. vmta referenced this in commit 56c40fe100 on Apr 27, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:52 UTC