tests: update Wycheproof #1711

pull fanquake wants to merge 2 commits into bitcoin-core:master from fanquake:update_wycheproof changing 4 files +10 −10
  1. fanquake commented at 1:18 PM on July 23, 2025: member

    Updates Wycheproof after https://github.com/C2SP/wycheproof/pull/150. Cherry-picks the commit from #1686 (let me know if you want this commit message changed).

  2. real-or-random added the label tweak/refactor on Jul 25, 2025
  3. real-or-random commented at 6:43 AM on July 25, 2025: contributor

    Can you also adjust the references in https://github.com/bitcoin-core/secp256k1/blob/master/src/wycheproof/WYCHEPROOF_COPYING?

  4. tests: update Wycheproof files
    Pulls in relevant changes from https://github.com/C2SP/wycheproof/pull/150.
    9ea54c69b7
  5. Fix typos and spellings 5433648ca0
  6. fanquake force-pushed on Jul 25, 2025
  7. fanquake commented at 8:17 AM on July 25, 2025: member

    Can you also adjust the references

    Fixed up.

  8. real-or-random approved
  9. real-or-random commented at 9:39 AM on July 25, 2025: contributor

    ACK 5433648ca0d2e8fb6679acbdee74d2f40c7ef25a

  10. in src/wycheproof/ecdsa_secp256k1_sha256_bitcoin_test.json:98 in 5433648ca0 
      94 | @@ -95,8 +95,8 @@
  95 |      },
  96 |      "SignatureMalleabilityBitcoin" : {
  97 |        "bugType" : "SIGNATURE_MALLEABILITY",
  98 | -      "description" : "\"BitCoins\"-curves are curves where signature malleability can be a serious issue. An implementation should only accept a signature s where s < n/2. If an implementation is not meant for uses cases that require signature malleability then this implementation should be tested with another set of test vectors.",
  99 | -      "effect" : "In bitcoin exchanges, it may be used to make a double deposits or double withdrawals",
 100 | +      "description" : "Signature malleability can be a serious issue in Bitcoin. An implementation should only accept a signature s where s < n/2. If an implementation is not meant for use cases that require signature malleability then this implementation should be tested with another set of test vectors.",
    josibake commented at 11:09 AM on July 25, 2025:

    I think this comment should read something like:

          "description" : "Signature malleability can be a serious issue in Bitcoin. An implementation should only accept a signature s where s < n/2. If an implementation is meant for use cases that require signature malleability then this implementation should be tested with another set of test vectors.",
    jonasnick commented at 2:07 PM on July 29, 2025:

    Only one test vector has the SignatureMalleabilityBitcoin flag and it tests a failing signature. So I cannot make sense of the original descriptioin either. Maybe it should say something like:

    If an implementation is meant for use cases that tolarete signature malleability then this implementation should not be tested with this set of test vectors.

    josibake commented at 3:39 PM on July 29, 2025:

    Opened https://github.com/C2SP/wycheproof/pull/153 upstream, will pipe through the changes to here if/when the upstream PR is merged.

  11. josibake commented at 11:10 AM on July 25, 2025: member

    ACK https://github.com/bitcoin-core/secp256k1/commit/5433648ca0d2e8fb6679acbdee74d2f40c7ef25a

    Left a note regarding one of the comments that was touched, but as I understand it this change would need to be made upstream anyways, so not a blocking comment.

    (happy to upsteam the change, if I'm understanding the intent of the comment correctly)

  12. jonasnick merged this on Jul 29, 2025
  13. jonasnick closed this on Jul 29, 2025
  14. fanquake deleted the branch on Jul 29, 2025
  15. josibake referenced this in commit e43bfd7dae on Jul 31, 2025
  16. josibake referenced this in commit c25c3c8a88 on Jul 31, 2025
  17. real-or-random referenced this in commit 74b8068c5d on Aug 1, 2025
  18. vmta referenced this in commit 2b25f561a0 on Sep 21, 2025
  19. fanquake referenced this in commit 42c7d35d3a on Oct 14, 2025
  20. fanquake referenced this in commit 3cbf7cb3e6 on Oct 15, 2025
  21. nymius referenced this in commit 3df3f5a0e3 on Nov 9, 2025
  22. Sjors referenced this in commit d5660d3a13 on Feb 16, 2026
  23. real-or-random referenced this in commit 42ae776d3b on Feb 25, 2026
  24. github-actions[bot] referenced this in commit c3f80fff5f on Mar 1, 2026
  25. github-actions[bot] referenced this in commit 758d4e90b4 on Mar 1, 2026
  26. github-actions[bot] referenced this in commit 4aeff8400e on Mar 1, 2026
  27. github-actions[bot] referenced this in commit 68a2178f22 on Mar 1, 2026
  28. github-actions[bot] referenced this in commit a8bc1a0b2b on Mar 1, 2026
  29. github-actions[bot] referenced this in commit 5f15eb0c55 on Mar 1, 2026
  30. 0x000000000019d6689c085ae165831e934ff76 referenced this in commit d54574beca on Mar 2, 2026
  31. 0x000000000019d6689c085ae165831e934ff76 referenced this in commit 3b9450150d on Mar 2, 2026
  32. csjones referenced this in commit fb3e16af04 on Mar 2, 2026
  33. csjones referenced this in commit a4d92824ae on Mar 2, 2026
Contributors
fanquakereal-or-randomjosibakejonasnick
Labels
tweak/refactor
Linked (view graph)
#1686 doc: Fix typos and spellings#1717 test: update wycheproof test vectors
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:52 UTC