Assert field magnitude at control-flow join #1673

pull peterdettman wants to merge 1 commits into bitcoin-core:master from peterdettman:join changing 1 files +2 −0
  1. peterdettman commented at 10:56 AM on May 20, 2025: contributor

    As I was re-reading the xonly method I noticed that the author had taken some care about the magnitude of g in each branch. It's probably worth documenting magnitude assumptions when control flows join like this.

    Actually I would even prefer a new field method (perhaps _fe_join) that calls SECP256K1_FE_VERIFY_MAGNITUDE, and then sets the magnitude to that value. That would be more in line with the static analysis view of magnitudes that I recall being discussed, though I have not been following closely lately.

  2. Assert field magnitude at control-flow join 3a4f448cb4
  3. sipa commented at 11:56 PM on May 20, 2025: contributor

    ACK 3a4f448cb46eae2aec991b95e4c686de2a4ba906

  4. jonasnick approved
  5. jonasnick commented at 5:48 AM on May 24, 2025: contributor

    ACK 3a4f448cb46eae2aec991b95e4c686de2a4ba906

  6. jonasnick merged this on May 24, 2025
  7. jonasnick closed this on May 24, 2025

  8. peterdettman deleted the branch on May 24, 2025
  9. hebasto referenced this in commit eb3b9cc612 on Jun 5, 2025
  10. hebasto referenced this in commit 68094d6972 on Jun 30, 2025
  11. Sjors referenced this in commit 1b7453ea88 on Jul 17, 2025
  12. hebasto referenced this in commit 28310efba4 on Jul 18, 2025
  13. fanquake referenced this in commit 5600e6fc4b on Jul 22, 2025
  14. saikiran57 referenced this in commit abe11bd67c on Jul 28, 2025
  15. janus referenced this in commit e0ffd31e87 on Sep 14, 2025
  16. vmta referenced this in commit 2b25f561a0 on Sep 21, 2025
  17. github-actions[bot] referenced this in commit 758d4e90b4 on Mar 1, 2026
  18. github-actions[bot] referenced this in commit 68a2178f22 on Mar 1, 2026
  19. github-actions[bot] referenced this in commit a8bc1a0b2b on Mar 1, 2026
  20. 0x000000000019d6689c085ae165831e934ff76 referenced this in commit 3b9450150d on Mar 2, 2026
  21. csjones referenced this in commit a4d92824ae on Mar 2, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:52 UTC