include: remove WARN_UNUSED_RESULT for functions always returning 1 #1659

pull jonasnick wants to merge 1 commits into bitcoin-core:master from jonasnick:rm-warn-unused-result changing 2 files +6 −6
  1. jonasnick commented at 9:37 AM on March 13, 2025: contributor

    This makes the usage of the atribute consistent. In the musig and ellswift module, functions that return 1 always already don't have the WARN_UNUSED_RESULT attribute. In secp256k1.h and the extrakeys module, this has only been the case partially.

    In all cases where this was removed, the function only returns 0 if the illegal callback has been called.

    Fixes #1379

  2. include: remove WARN_UNUSED_RESULT for functions always returning 1
    This makes the usage of the atribute consistent. In the musig and ellswift
    module, functions that return 1 always already don't have the WARN_UNUSED_RESULT
    attribute. In secp256k1.h and the extrakeys module, this has only been the case
    partially.
    
    In all cases where this was removed, the function only returns 0 if the illegal
    callback has been called.
    1b6e081538
  3. jonasnick added the label needs-changelog on Mar 13, 2025
  4. real-or-random added the label assurance on Mar 13, 2025
  5. real-or-random added the label refactor/smell on Mar 13, 2025
  6. real-or-random approved
  7. sipa commented at 12:15 PM on March 13, 2025: contributor

    utACK 1b6e081538cc9a171157ec858c4aac19deb7d6cc

  8. real-or-random merged this on Mar 13, 2025
  9. real-or-random closed this on Mar 13, 2025

  10. hebasto referenced this in commit dd59896431 on Mar 17, 2025
  11. fjahr referenced this in commit cd1404164e on Mar 23, 2025
  12. hebasto referenced this in commit 017ff1c67c on May 8, 2025
  13. hebasto referenced this in commit c31fcaaad3 on May 13, 2025
  14. fanquake referenced this in commit 8309a9747a on May 13, 2025
  15. vmta referenced this in commit 3a0314c68f on May 22, 2025
  16. real-or-random referenced this in commit 6037833c9e on Jul 21, 2025
  17. fanquake removed the label needs-changelog on Jul 29, 2025
  18. fanquake commented at 10:26 AM on July 29, 2025: member

    Changelog was added in #1702. Dropping "needs-changelog".

  19. janus referenced this in commit 498ffcb50b on Sep 7, 2025
  20. real-or-random referenced this in commit 6e071d18ba on Feb 23, 2026
  21. github-actions[bot] referenced this in commit 758d4e90b4 on Mar 1, 2026
  22. github-actions[bot] referenced this in commit 68a2178f22 on Mar 1, 2026
  23. github-actions[bot] referenced this in commit a8bc1a0b2b on Mar 1, 2026
  24. 0x000000000019d6689c085ae165831e934ff76 referenced this in commit 3b9450150d on Mar 2, 2026
  25. csjones referenced this in commit a4d92824ae on Mar 2, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:52 UTC