examples: do not retry generating seckey randomness in musig #1616

pull jonasnick wants to merge 3 commits into bitcoin-core:master from jonasnick:example-musig-key changing 7 files +31 −27
  1. jonasnick commented at 7:33 AM on October 13, 2024: contributor

    Follow-up to #1570.

  2. jonasnick force-pushed on Oct 13, 2024
  3. jonasnick force-pushed on Oct 14, 2024
  4. jonasnick marked this as ready for review on Oct 14, 2024
  5. real-or-random added the label user-documentation on Oct 14, 2024
  6. real-or-random added the label refactor/smell on Oct 14, 2024
  7. in include/secp256k1_extrakeys.h:164 in dad5db0428 outdated 
     162 | - *           0: secret was invalid, try again with a different secret
 163 | + *  See the documentation of `secp256k1_ec_seckey_verify` for more information
 164 | + *  about the validity of secret keys.
 165 | + *
 166 | + *  Returns: 1: secret was valid
 167 | + *           0: secret was invalid
    real-or-random commented at 8:43 AM on October 14, 2024:

    nit: If we're touching this, just say "secret key"? (And not that it matters, but it appears that we usually use present tense in these descriptions)

     *  Returns: 1: secret key is valid
 *           0: secret key is invalid
    jonasnick commented at 1:24 PM on October 14, 2024:

    Good idea, done.

  8. real-or-random approved
  9. real-or-random commented at 8:45 AM on October 14, 2024: contributor

    utACK dad5db04280eac99f6ac95f034058767512df90d

  10. extrakeys: improve doc of keypair_create (don't suggest retry) 70b6be1834
  11. examples: do not retry generating seckey randomness in musig e8908221a4
  12. examples: make key generation doc consistent 5bab8f6d3c
  13. jonasnick force-pushed on Oct 14, 2024
  14. real-or-random approved
  15. real-or-random commented at 2:20 PM on October 14, 2024: contributor

    utACK 5bab8f6d3c4946f32bebd2a99b9975aa160ff794

  16. theStack approved
  17. theStack commented at 3:22 PM on October 14, 2024: contributor

    ACK 5bab8f6d3c4946f32bebd2a99b9975aa160ff794

  18. real-or-random merged this on Oct 14, 2024
  19. real-or-random closed this on Oct 14, 2024
  20. hebasto referenced this in commit 5c425b5703 on Oct 16, 2024
  21. achow101 referenced this in commit c24b343141 on Oct 24, 2024
  22. vmta referenced this in commit 4d1f6d5635 on Oct 29, 2024
  23. achow101 referenced this in commit 378ca17fd1 on Nov 1, 2024
  24. achow101 referenced this in commit 2d46a89386 on Nov 4, 2024
  25. Eunovo referenced this in commit 55a2f7a840 on Nov 12, 2024
  26. vmta referenced this in commit f40affbf6c on Nov 21, 2024
  27. vmta referenced this in commit cc8d145633 on Nov 22, 2024
  28. janus referenced this in commit a4b4239cb4 on Jan 19, 2025
  29. div72 referenced this in commit af627d47c3 on Apr 12, 2025
  30. real-or-random referenced this in commit 8aa05cb351 on Feb 17, 2026
  31. github-actions[bot] referenced this in commit 758d4e90b4 on Mar 1, 2026
  32. github-actions[bot] referenced this in commit 68a2178f22 on Mar 1, 2026
  33. github-actions[bot] referenced this in commit a8bc1a0b2b on Mar 1, 2026
  34. 0x000000000019d6689c085ae165831e934ff76 referenced this in commit 3b9450150d on Mar 2, 2026
  35. csjones referenced this in commit a4d92824ae on Mar 2, 2026
Contributors
jonasnickreal-or-randomtheStack
Labels
user-documentationtweak/refactor
Linked (view graph)
#1570 Examples should not retry on bad randomness keys in a loop
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:52 UTC