cmake: Introduce `SECP256K1_APPEND_LDFLAGS` variable #1600

pull hebasto wants to merge 1 commits into bitcoin-core:master from hebasto:240902-append-ldflags changing 1 files +11 −0
  1. hebasto commented at 8:42 PM on September 2, 2024: member

    Downstream projects may include libsecp256k1 test executables in their test suites. In such cases, if a -fsanitize=... flag is passed via the SECP256K1_APPEND_CFLAGS variable, the same flag must also be passed to the linker.

    Required for https://github.com/bitcoin/bitcoin/pull/30791.

  2. cmake: Introduce `SECP256K1_APPEND_LDFLAGS` variable
    Downstream projects may include libsecp test executables in their test
    suites. In such cases, if a `-fsanitize=...` flag is passed via the
    `SECP256K1_APPEND_CFLAGS` variable, the same flag must also be passed to
    the linker.
    421ed1b46f
  3. fanquake commented at 9:54 AM on September 6, 2024: member

    Concept ACK - It'd be great if a maintainer could take a look, as we have some changes downstream that are blocked on this.

  4. jonasnick approved
  5. jonasnick commented at 5:02 PM on September 7, 2024: contributor

    @real-or-random sent me a message that he utACKs this and I tested that it works.

    ACK 421ed1b46ff018f33a497df913a11d20f8dd1acc

  6. jonasnick merged this on Sep 7, 2024
  7. jonasnick closed this on Sep 7, 2024

  8. hebasto deleted the branch on Sep 7, 2024
  9. hebasto referenced this in commit 611562806c on Sep 7, 2024
  10. fanquake referenced this in commit df86a4f333 on Sep 9, 2024
  11. fanquake referenced this in commit e4fb97a512 on Sep 10, 2024
  12. vmta referenced this in commit d5f931329c on Sep 25, 2024
  13. vmta referenced this in commit 4d1f6d5635 on Oct 29, 2024
  14. vmta referenced this in commit f40affbf6c on Nov 21, 2024
  15. vmta referenced this in commit cc8d145633 on Nov 22, 2024
  16. janus referenced this in commit c1f7fc953e on Jan 12, 2025
  17. janus referenced this in commit b5fe403b11 on Jan 12, 2025
  18. div72 referenced this in commit af627d47c3 on Apr 12, 2025
  19. real-or-random referenced this in commit 211323d6b7 on Feb 13, 2026
  20. github-actions[bot] referenced this in commit 758d4e90b4 on Mar 1, 2026
  21. github-actions[bot] referenced this in commit 68a2178f22 on Mar 1, 2026
  22. github-actions[bot] referenced this in commit a8bc1a0b2b on Mar 1, 2026
  23. 0x000000000019d6689c085ae165831e934ff76 referenced this in commit 3b9450150d on Mar 2, 2026
  24. csjones referenced this in commit a4d92824ae on Mar 2, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:52 UTC