build, ci: Adjust the default size of the precomputed table for signing #1564

pull hebasto wants to merge 2 commits into bitcoin-core:master from hebasto:240701-default-emsize changing 3 files +4 −4
  1. hebasto commented at 7:52 PM on July 1, 2024: member

    This PR implements the outcomes from today's IRC meeting:

    1. The default size of the precomputed table for signing is now aligned with Bitcoin Core's default.

    2. The default value in CI has been updated to reflect the new default.

  2. real-or-random added the label ci on Jul 1, 2024
  3. real-or-random added the label build on Jul 1, 2024
  4. real-or-random added the label performance on Jul 1, 2024
  5. build: Adjust the default size of the precomputed table for signing
    The new default value of the precomputed table for signing is aligned
with Bitcoin Core's default.
See: https://github.com/bitcoin/bitcoin/commit/a057869aa3c42457570765966cb66accb2375b13
    d94a9273f8
  6. ci: Switch to the new default value of the precomputed table for signing e2af491263
  7. hebasto force-pushed on Jul 3, 2024
  8. real-or-random added the label needs-changelog on Jul 3, 2024
  9. real-or-random commented at 1:49 PM on July 3, 2024: contributor

    @sipa @jonasnick

    I wonder how much this is a breaking change. 86 KB is larger than the old default (64KB), so this could be a problem for some users. But since we use static precomputation, this will be at most a build-time issue, so I don't think it deserves a 0.6.0 instead of 0.5.1 (assuming it makes it to the next release).

  10. hebasto commented at 1:51 PM on July 3, 2024: member

    ... I don't think it deserves a 0.6.0 instead of 0.5.1 (assuming it makes it to the next release).

    I agree because there are no API changes.

  11. real-or-random approved
  12. real-or-random commented at 1:53 PM on July 3, 2024: contributor

    utACK e2af491263e2f7e086dc7f1925d86660ff265dc6

  13. sipa commented at 3:00 PM on July 3, 2024: contributor

    utACK e2af491263e2f7e086dc7f1925d86660ff265dc6

    I agree this is not a breaking change, though it does deserve a release note.

  14. real-or-random merged this on Jul 3, 2024
  15. real-or-random closed this on Jul 3, 2024
  16. hebasto deleted the branch on Jul 3, 2024
  17. fanquake referenced this in commit 41797f8ab9 on Aug 2, 2024
  18. fanquake referenced this in commit d928f4c47f on Aug 6, 2024
  19. vmta referenced this in commit f2a8540eae on Sep 3, 2024
  20. vmta referenced this in commit 8c2166b973 on Sep 6, 2024
  21. vmta referenced this in commit 4d1f6d5635 on Oct 29, 2024
  22. real-or-random removed the label needs-changelog on Nov 4, 2024
  23. janus referenced this in commit 1fed89422a on Jan 6, 2025
  24. div72 referenced this in commit af627d47c3 on Apr 12, 2025
  25. oskarszoon referenced this in commit 0d5c9260f4 on Jul 1, 2025
  26. real-or-random referenced this in commit 4ae7cb4f71 on Feb 11, 2026
  27. github-actions[bot] referenced this in commit 758d4e90b4 on Mar 1, 2026
  28. github-actions[bot] referenced this in commit 68a2178f22 on Mar 1, 2026
  29. github-actions[bot] referenced this in commit a8bc1a0b2b on Mar 1, 2026
  30. 0x000000000019d6689c085ae165831e934ff76 referenced this in commit 3b9450150d on Mar 2, 2026
  31. csjones referenced this in commit a4d92824ae on Mar 2, 2026
Contributors
hebastoreal-or-randomsipa
Labels
cibuildperformance
Linked (view graph)
#1549 discussion: Config used by Core vs defaults and config in CI/testing
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:52 UTC