Hello,
This Pull Request fixes the issue reported in #1527. Function secp256k1_ecmult_multi_var expects to be called with a non-NULL error_callback parameter. Fix the invocation in test_ecmult_accumulate to do this. While at it, wrap the call in a CHECK macro to ensure it succeeds.
tests: call `secp256k1_ecmult_multi_var` with a non-`NULL` error callback #1528
pull niooss-ledger wants to merge 1 commits into bitcoin-core:master from niooss-ledger:fix-tests-not-null-error-callback changing 1 files +2 −2-
niooss-ledger commented at 5:17 PM on May 8, 2024: contributor
-
9554362b15
tests: call secp256k1_ecmult_multi_var with a non-NULL error callback
Function secp256k1_ecmult_multi_var expects to be called with a non-NULL error_callback parameter. Fix the invocation in test_ecmult_accumulate to do this. While at it, wrap the call in a CHECK macro to ensure it succeeds. Fixes: https://github.com/bitcoin-core/secp256k1/issues/1527
- real-or-random approved
-
real-or-random commented at 7:49 AM on May 9, 2024: contributor
utACK 9554362b1532d8292ab805cefb9c886cd55ac205
- real-or-random added the label bug on May 9, 2024
- real-or-random added the label assurance on May 9, 2024
-
siv2r commented at 8:43 AM on May 13, 2024: contributor
ACK 9554362, I have also verified that other invocations of
ecmult_multi_var(in tests) don’t useNULLfor the error callback function argument. - real-or-random merged this on May 13, 2024
- real-or-random closed this on May 13, 2024
- niooss-ledger deleted the branch on May 13, 2024
- fanquake referenced this in commit ca3d945dc6 on May 16, 2024
- vmta referenced this in commit f75d43863d on May 22, 2024
- janus referenced this in commit 4a09aa7cc4 on Jun 6, 2024
- vmta referenced this in commit c16ce221c4 on Sep 6, 2024
- vmta referenced this in commit 4d1f6d5635 on Oct 29, 2024
- div72 referenced this in commit af627d47c3 on Apr 12, 2025
- oskarszoon referenced this in commit 0d5c9260f4 on Jul 1, 2025
- github-actions[bot] referenced this in commit 758d4e90b4 on Mar 1, 2026
- github-actions[bot] referenced this in commit 68a2178f22 on Mar 1, 2026
- github-actions[bot] referenced this in commit a8bc1a0b2b on Mar 1, 2026
- 0x000000000019d6689c085ae165831e934ff76 referenced this in commit 3b9450150d on Mar 2, 2026
- csjones referenced this in commit a4d92824ae on Mar 2, 2026
