Resolves one item in #1235. Closes #1294.
cc @hebasto
cmake: Recommend native CMake commands in README #1483
pull real-or-random wants to merge 1 commits into bitcoin-core:master from real-or-random:202401-cmake-native-readme changing 1 files +3 −3-
real-or-random commented at 2:25 PM on January 17, 2024: contributor
-
3777e3f36a
cmake: Recommend native CMake commands in README
Resolves one item in #1235. Closes #1294.
- real-or-random added the label user-documentation on Jan 17, 2024
- real-or-random added the label build on Jan 17, 2024
-
in README.md:81 in 3777e3f36a
78 | @@ -79,9 +79,9 @@ To maintain a pristine source tree, CMake encourages to perform an out-of-source 79 | 80 | $ mkdir build && cd build 81 | $ cmake ..
hebasto commented at 11:08 AM on January 18, 2024:nit: Might be explicit:
$ cmake -S ..?
real-or-random commented at 2:17 PM on January 18, 2024:Hm, yeah, I think shorter is better, and omitting the -S is also more common. (See the official tutorial https://cmake.org/cmake/help/latest/guide/tutorial/A%20Basic%20Starting%20Point.html for example.)
hebasto commented at 3:32 PM on January 18, 2024:OK, nm.
in README.md:84 in 3777e3f36a
78 | @@ -79,9 +79,9 @@ To maintain a pristine source tree, CMake encourages to perform an out-of-source 79 | 80 | $ mkdir build && cd build 81 | $ cmake .. 82 | - $ make 83 | - $ make check # run the test suite 84 | - $ sudo make install # optional 85 | + $ cmake --build . 86 | + $ ctest # run the test suite 87 | + $ sudo cmake --build . --target install # optional
hebasto commented at 11:10 AM on January 18, 2024:Is it worth mentioning a modern and more effective alternative, which is available for CMake >= 3.15:
$ sudo cmake --install . # optional?
real-or-random commented at 2:19 PM on January 18, 2024:Thanks for the suggestion. In fact, I had this first, but I changed to the current form because we still support CMake 3.13.
hebasto commented at 3:33 PM on January 18, 2024:I mean, mention it additionally, not instead of the current line.
hebasto commented at 3:34 PM on January 18, 2024:However, it's OK in its current view.
hebasto approvedhebasto commented at 11:11 AM on January 18, 2024: memberACK 3777e3f36a61a05da19d5c6575fdd59288848948
jonasnick approvedjonasnick commented at 7:34 PM on January 23, 2024: contributorACK 3777e3f36a61a05da19d5c6575fdd59288848948
jonasnick merged this on Jan 23, 2024jonasnick closed this on Jan 23, 2024fjahr referenced this in commit d5f970e647 on Feb 25, 2024achow101 referenced this in commit b525369f8e on Mar 25, 2024achow101 referenced this in commit 2189d2f841 on Apr 1, 2024fanquake referenced this in commit 5354807b00 on Apr 4, 2024fanquake referenced this in commit 53eec53dca on Apr 4, 2024hebasto referenced this in commit b6de625950 on May 11, 2024vmta referenced this in commit 2ef958bb88 on May 20, 2024janus referenced this in commit 939262869a on Jun 6, 2024div72 referenced this in commit af627d47c3 on Apr 12, 2025oskarszoon referenced this in commit 0d5c9260f4 on Jul 1, 2025real-or-random referenced this in commit 7e460db4ca on Jan 29, 2026github-actions[bot] referenced this in commit 758d4e90b4 on Mar 1, 2026github-actions[bot] referenced this in commit 68a2178f22 on Mar 1, 2026github-actions[bot] referenced this in commit a8bc1a0b2b on Mar 1, 20260x000000000019d6689c085ae165831e934ff76 referenced this in commit 3b9450150d on Mar 2, 2026csjones referenced this in commit a4d92824ae on Mar 2, 2026
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:52 UTC
This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:52 UTC