asm: add .note.GNU-stack section for non-exec stack #1441

pull fanquake wants to merge 1 commits into bitcoin-core:master from fanquake:avoid_exec_stack_ld changing 1 files +1 −0

fanquake commented at 2:52 PM on November 13, 2023: member

With this in place, we no-longer see warnings like the following:

/usr/lib/gcc-cross/arm-linux-gnueabihf/12/../../../../arm-linux-gnueabihf/bin/ld: warning: field_10x26_arm.o: missing .note.GNU-stack section implies executable stack
/usr/lib/gcc-cross/arm-linux-gnueabihf/12/../../../../arm-linux-gnueabihf/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker

Should close #1434.

asm: add .note.GNU-stack section for non-exec stack

With this in place, we no-longer see warnings like the following:
```bash
/usr/lib/gcc-cross/arm-linux-gnueabihf/12/../../../../arm-linux-gnueabihf/bin/ld: warning: field_10x26_arm.o: missing .note.GNU-stack section implies executable stack
/usr/lib/gcc-cross/arm-linux-gnueabihf/12/../../../../arm-linux-gnueabihf/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
```

Should close #1434.

33dc7e4d3e

real-or-random approved
real-or-random commented at 6:12 PM on November 13, 2023: contributor

utACK 33dc7e4d3e1947af4c84c09ecc75ea2eeed3f7e0
real-or-random commented at 6:14 PM on November 13, 2023: contributor

With this in place, we no-longer see warnings like the following:

Just for clarification: Is "you" Bitcoin Core? As far as I know, the ARM assembly shouldn't be enabled there. (We still consider it experimental, though that's a bit unfortunate because don't have a plan for stabilizing it...)
real-or-random added the label build on Nov 13, 2023
real-or-random added the label refactor/smell on Nov 13, 2023
fanquake commented at 6:16 PM on November 13, 2023: member

Just for clarification: Is "you" Bitcoin Core?

I only tested this within a local checkout of libsecp, not with Core/anywhere else.
sipa commented at 2:31 PM on November 15, 2023: contributor

utACK 33dc7e4d3e1947af4c84c09ecc75ea2eeed3f7e0
real-or-random merged this on Nov 16, 2023
real-or-random closed this on Nov 16, 2023
fanquake deleted the branch on Nov 16, 2023
hebasto commented at 10:22 AM on November 16, 2023: member

Post-merge ACK 33dc7e4d3e1947af4c84c09ecc75ea2eeed3f7e0.

I only tested this within a local checkout of libsecp, not with Core/anywhere else.

Tested for Bitcoin Core in the Guix build process, which includes security checks.

Forcing --with-asm=arm32 causes a failure in the check_NX security test.

This PR diff fixes it.
real-or-random commented at 1:32 PM on November 16, 2023: contributor

Forcing --with-asm=arm32 causes a failure in the check_NX security test.

This PR diff fixes it.

Thanks, that's reassuring!
fanquake referenced this in commit 41e1b677ca on Jan 3, 2024
fanquake referenced this in commit 29fde0223a on Jan 4, 2024
janus referenced this in commit 5fe435c9b2 on Apr 6, 2024
hebasto referenced this in commit b6de625950 on May 11, 2024
delta1 referenced this in commit 6089844b3c on Apr 2, 2025
div72 referenced this in commit af627d47c3 on Apr 12, 2025
str4d referenced this in commit 136aa9fe62 on Jun 4, 2025
oskarszoon referenced this in commit 0d5c9260f4 on Jul 1, 2025

Contributors

Labels

Linked (view graph)

#1434 ARM assembly: "missing .note.GNU-stack section implies executable stack" with recent ld