ci: Move remained task from Cirrus to GitHub Actions #1409

pull hebasto wants to merge 4 commits into bitcoin-core:master from hebasto:230821-gha-all changing 2 files +238 −159
  1. hebasto commented at 1:58 PM on August 22, 2023: member

    This PR concludes the migration from Cirrus CI to GitHub Actions.

  2. in .github/workflows/ci.yml:529 in 1961f18a7f outdated 
     482 | +        uses: ./.github/actions/run-in-docker-action
 483 | +        with:
 484 | +          dockerfile: ./ci/linux-debian.Dockerfile
 485 | +          tag: linux-debian-image
 486 | +          command: >
 487 | +            git config --global --add safe.directory ${{ github.workspace }} &&
    real-or-random commented at 2:48 PM on August 22, 2023:

    Not this PR, but now that I see this, couldn't we add this to run-in-docker-action to avoid duplication?

    (did I ask this before?)

    hebasto commented at 3:13 PM on August 22, 2023:

    (did I ask this before?)

    We discussed whether it should be placed in ci.sh.

    UPD. ... as it's done in bitcoin repo.

    real-or-random commented at 8:49 AM on August 23, 2023:

    Ok, sure, I remember now. I still think this should not be in ci.sh, but yeah, we could consider moving it to run-in-docker-action (in a separate PR probably).

    hebasto commented at 2:00 PM on August 23, 2023:

    Done in #1411.

  3. real-or-random added the label ci on Aug 22, 2023
  4. in .github/workflows/ci.yml:420 in 1961f18a7f outdated 
     415 | +
 416 | +      - name: Set environment variables
 417 | +        run: |
 418 | +          for var in "$(jq -s 'add' <<< '${{ toJSON(matrix.configuration.env_vars) }} ${{ toJSON(matrix.asm.env_vars) }} ${{ toJSON(matrix.cc.env_vars) }}' | jq -r 'to_entries | .[] | "\(.key)=\(.value)"')"; do
 419 | +            echo "$var" >> "$GITHUB_ENV"
 420 | +          done
    real-or-random commented at 3:05 PM on August 22, 2023:

    A bit ugly, hm... There's no better way to merge this, I guess.

    I think it makes sense to split this job into two jobs "Valgrind (memcheck)" and "UBSan, ASan, LSan". Then for each of these jobs, we can expand the remaining 2x2 combinations, i.e., list the 4 resulting combinations explicitly. This is probably a good idea anyway, it will also make it a bit easier to add variety to the jobs.

    What do you think?

    hebasto commented at 3:11 PM on August 22, 2023:

    I think it makes sense to split this job into two jobs "Valgrind (memcheck)" and "UBSan, ASan, LSan".

    I was thinking about the same. But it won't help.

    Only one env property is allowed job-wide and step-wide. Job-wide env is already busy with global variables. Therefore, even 2 sets won't fit one step-wide env.

    hebasto commented at 3:15 PM on August 22, 2023:

    list the 4 resulting combinations explicitly

    ... but that is completely feasible.

    hebasto commented at 7:01 PM on August 22, 2023:

    list the 4 resulting combinations explicitly

    ... but that is completely feasible.

    Done.

  5. hebasto force-pushed on Aug 22, 2023
  6. ci: Move sanitizers task from Cirrus to GitHub Actions c22ac27529
  7. ci: Move "MSan" from Cirrus to GitHub Actions d51fb0a533
  8. ci: Move "C++ -fpermissive..." from Cirrus to GitHub Actions 61fc3a2dc8
  9. ci: Move "C++ (public headers)" from Cirrus to GitHub Actions 676ed8f9cf
  10. in .github/workflows/ci.yml:787 in 1b51315e60 outdated 
     782 | +        with:
 783 | +          dockerfile: ./ci/linux-debian.Dockerfile
 784 | +          tag: linux-debian-image
 785 | +          command: >
 786 | +            g++ -Werror include/*.h &&
 787 | +            clang -Werror -x c++-header include/*.h
    real-or-random commented at 9:01 AM on August 23, 2023:

    nit: it's probably more convenient to run clang even if g++ fails

                g++ -Werror include/*.h
            clang -Werror -x c++-header include/*.h

    (I think that linebreak should work. Or do we need a ; here?)

    hebasto commented at 10:00 AM on August 23, 2023:

    Thanks! Reworked.

  11. hebasto force-pushed on Aug 23, 2023
  12. real-or-random approved
  13. real-or-random commented at 12:53 PM on August 23, 2023: contributor

    ACK 676ed8f9cf001ebaadf53d5c11e32f7a6b1e5649

  14. real-or-random merged this on Aug 23, 2023
  15. real-or-random closed this on Aug 23, 2023
  16. hebasto deleted the branch on Aug 23, 2023
  17. real-or-random referenced this in commit ea26b71c3a on Aug 24, 2023
  18. sipa referenced this in commit c0da4f60e2 on Sep 4, 2023
  19. Retropex referenced this in commit 5f62ed90f6 on Oct 4, 2023
  20. real-or-random referenced this in commit d575ef9aca on Oct 12, 2023
  21. janus referenced this in commit 1097330147 on Apr 1, 2024
  22. hebasto referenced this in commit b6de625950 on May 11, 2024
  23. delta1 referenced this in commit 6089844b3c on Apr 2, 2025
  24. div72 referenced this in commit af627d47c3 on Apr 12, 2025
  25. str4d referenced this in commit b9e749419a on Jun 4, 2025
  26. Fabcien referenced this in commit 494d1e3970 on Feb 5, 2026
  27. Fabcien referenced this in commit 53f368bff5 on Feb 5, 2026
  28. Fabcien referenced this in commit 37fd942dd6 on Feb 5, 2026
  29. Fabcien referenced this in commit 48ba449989 on Feb 5, 2026
  30. Fabcien referenced this in commit f4c3fb1147 on Feb 5, 2026
  31. Fabcien referenced this in commit 181de403d2 on Feb 5, 2026
Contributors
hebastoreal-or-random
Labels
ci
Linked (view graph)
#1392 ci: Future of CI after Cirrus pricing change #1411 ci: Make repetitive command the default one
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:52 UTC